Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35596: Fix vcruntime140.dll being added to embeddable distro multiple times. #11329

Merged
merged 2 commits into from
Dec 27, 2018
Merged

bpo-35596: Fix vcruntime140.dll being added to embeddable distro multiple times. #11329

merged 2 commits into from
Dec 27, 2018

Conversation

zooba
Copy link
Member

@zooba zooba commented Dec 27, 2018 •
edited by bedevere-bot
Loading

@zooba zooba requested a review from a team as a code owner December 27, 2018 20:26
@miss-islington
Copy link
Contributor

@zooba: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 59c2aa2 into python:master Dec 27, 2018
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@zooba zooba deleted the fix-double-vcruntime branch December 27, 2018 20:44
@bedevere-bot
Copy link

GH-11331 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 27, 2018
@zooba @miss-islington
bpo-35596: Fix vcruntime140.dll being added to embeddable distro mult…
98da7c5 
…iple times. (pythonGH-11329)

https://bugs.python.org/issue35596
(cherry picked from commit 59c2aa2)

Co-authored-by: Steve Dower <[email protected]>
miss-islington added a commit that referenced this pull request Dec 28, 2018
@miss-islington @zooba
bpo-35596: Fix vcruntime140.dll being added to embeddable distro mult…
bbf6954 
…iple times. (GH-11329)

https://bugs.python.org/issue35596
(cherry picked from commit 59c2aa2)

Co-authored-by: Steve Dower <[email protected]>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86-64 High Sierra 3.7 has failed when building commit bbf6954.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/147/builds/581) and take a look at the build logs.
  4. Check if the failure is related to this commit (bbf6954) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/147/builds/581

Click to see traceback logs 
Reset branch '3.7'

Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
OS-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zooba @miss-islington @bedevere-bot @the-knights-who-say-ni