Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-108269: Add CFBundleAllowMixedLocalizations to Info.plist on macOS #113213

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

ronaldoussoren
Copy link
Contributor

@ronaldoussoren ronaldoussoren commented Dec 16, 2023

Adding this key with a value of true enables detecting the users prefered language in libraries accessing system APIs for this.

… macOS

Adding this key with a value of true enables detecting the
users prefered language in libraries accessing system APIs
for this.
@ronaldoussoren
Copy link
Contributor Author

@ned-deily, what's your opinion on back porting this to 3.11 and 3.12?

I'm leaning toward seeing this a more as a new feature that shouldn't be back ported, but might be too conservative here. Anyone packaging GUI apps using py2app or pyinstaller can already set the Info.plist property for their app and this only affects command-line usage. Backporting should be safe enough.

@ned-deily
Copy link
Member

@ned-deily, what's your opinion on back porting this to 3.11 and 3.12?

This seems like something that could be considered either a bug or a feature. I don't have a strong opinion one way or the other. As you say, it's easy enough to work around when bundling an app. But it might be nice to fix. Perhaps compromise and just backport to 3.12 since it's still relatively early in its release cycle?

@ned-deily ned-deily merged commit 4cfce3a into python:main Dec 18, 2023
33 checks passed
@ned-deily
Copy link
Member

I merged this PR so that it will get exposure in the upcoming 3.13.0a3 preview. I will leave the backport decision to @ronaldoussoren.

@ronaldoussoren ronaldoussoren added the needs backport to 3.12 bug and security fixes label Dec 19, 2023
@miss-islington-app
Copy link

Thanks @ronaldoussoren for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 19, 2023
… macOS (pythonGH-113213)

Adding this key with a value of true enables detecting the
users prefered language in libraries accessing system APIs
for this.
(cherry picked from commit 4cfce3a)

Co-authored-by: Ronald Oussoren <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Dec 19, 2023

GH-113294 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Dec 19, 2023
@ronaldoussoren
Copy link
Contributor Author

I'm going to be conservative with the back port and only back port to 3.12.

ronaldoussoren added a commit that referenced this pull request Dec 19, 2023
…n macOS (GH-113213) (#113294)

gh-108269: Add CFBundleAllowMixedLocalizations to Info.plist on macOS (GH-113213)

Adding this key with a value of true enables detecting the
users prefered language in libraries accessing system APIs
for this.
(cherry picked from commit 4cfce3a)

Co-authored-by: Ronald Oussoren <[email protected]>
ryan-duve pushed a commit to ryan-duve/cpython that referenced this pull request Dec 26, 2023
… macOS (pythonGH-113213)

Adding this key with a value of true enables detecting the
users prefered language in libraries accessing system APIs
for this.
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
… macOS (pythonGH-113213)

Adding this key with a value of true enables detecting the
users prefered language in libraries accessing system APIs
for this.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
… macOS (pythonGH-113213)

Adding this key with a value of true enables detecting the
users prefered language in libraries accessing system APIs
for this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants