Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35567: Convert dict of constants to a set #11296

Merged
merged 1 commit into from
Dec 23, 2018
Merged

bpo-35567: Convert dict of constants to a set #11296

merged 1 commit into from
Dec 23, 2018

Conversation

csabella
Copy link
Contributor

@csabella csabella commented Dec 23, 2018 •
edited by bedevere-bot
Loading

  • Dictionary _hoppish is used to check if the header name exists, but only the key is used and not the value. This converts it to a set.
  • Tests already exist for the function that uses _hoppish and they still pass after the change.

https://bugs.python.org/issue35567

@csabella
bpo-35567: Convert dict of constants to a set
2183391 
* Dictionary ``_hoppish`` is used to check if the header name
  exists, but only the key is used and not the value.  This
  converts it to a set.
@serhiy-storchaka
Copy link
Member

Currently _hoppish is set to a bound method and called in is_hop_by_hop(). It could be clearer and faster if make it a set instance and use the in operator in is_hop_by_hop().

@rhettinger rhettinger merged commit 6815155 into python:master Dec 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger rhettinger approved these changes

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@csabella @serhiy-storchaka @rhettinger @the-knights-who-say-ni @bedevere-bot