Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bool in fileinput.input inplace docstring and tests #111998

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

scop
Copy link
Contributor

@scop scop commented Nov 12, 2023

The .rst docs, most tests, and typeshed already use bool for it.

The `.rst` docs, most tests, and typeshed already use bool for it.
@scop
Copy link
Contributor Author

scop commented Nov 12, 2023

I could add the news entry and an issue, but I think it would be just noise for this; suggesting someone to add skip news and skip issue labels instead.

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka merged commit a768e12 into python:main Jan 27, 2024
30 checks passed
@scop scop deleted the refactor/fileinput-inplace-bool branch January 28, 2024 07:18
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
…ument (pythonGH-111998)

The `.rst` docs, most tests, and typeshed already use bool for it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants