Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-111460: restore ncurses widechar support on macOS #111878

Merged
merged 1 commit into from
Nov 13, 2023
Merged

gh-111460: restore ncurses widechar support on macOS #111878

merged 1 commit into from
Nov 13, 2023

Conversation

sorcio
Copy link
Contributor

@sorcio sorcio commented Nov 9, 2023 •
edited by bedevere-app bot
Loading

Ncurses wide character support on macOS was broken as an unintended consequence of #94452. It is now built as intended.

@bedevere-app bedevere-app bot mentioned this pull request Nov 9, 2023
Closed
@erlend-aasland
Copy link
Contributor

Do you have the bandwidth to review this, @corona10?

@corona10
Copy link
Member

This weekend I will try :)

@corona10 corona10 added the needs backport to 3.12 bug and security fixes label Nov 13, 2023
corona10
corona10 approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

I checked that what kinds of value $have_curses can have from source codes

cpython/configure.ac

Lines 6255 to 6271 in e1a1e32

AS_VAR_IF([ac_cv_header_ncurses_h], [yes], [
if test "$ac_sys_system" != "Darwin"; then
dnl On macOS, there is no separate /usr/lib/libncursesw nor libpanelw.
PKG_CHECK_MODULES([CURSES], [ncursesw], [
AC_DEFINE([HAVE_NCURSESW], [1])
have_curses=ncursesw
], [
WITH_SAVE_ENV([
AC_CHECK_LIB([ncursesw], [initscr], [
AC_DEFINE([HAVE_NCURSESW], [1])
have_curses=ncursesw
CURSES_CFLAGS=${CURSES_CFLAGS-""}
CURSES_LIBS=${CURSES_LIBS-"-lncursesw"}
])
])
])
fi

Thanks for catching this.
This PR should be backported

@corona10 corona10 merged commit d2f305d into python:main Nov 13, 2023
34 checks passed
@miss-islington-app
Copy link

Thanks @sorcio for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 13, 2023
@sorcio @miss-islington
pythongh-111460: Restore ncurses widechar support on macOS (pythonGH-…
7f106a6 
…111878)

(cherry picked from commit d2f305d)

Co-authored-by: Davide Rizzo <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 13, 2023

GH-112034 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Nov 13, 2023
corona10 pushed a commit that referenced this pull request Nov 14, 2023
@miss-islington @sorcio
[3.12] gh-111460: Restore ncurses widechar support on macOS (GH-111878)…
d34650e 
… (gh-112034)

gh-111460: Restore ncurses widechar support on macOS (GH-111878)
(cherry picked from commit d2f305d)

Co-authored-by: Davide Rizzo <[email protected]>
@sorcio sorcio deleted the macos-restore-ncursesw branch November 14, 2023 16:55
@Turakar
Copy link

Turakar commented Jan 17, 2024

Might it be that a similar fix needs to be applied to the following line:

cpython/configure.ac

Line 6265 in f497525

if test "$ac_sys_system" != "Darwin"; then

It seems to me like this check is equally broken.

@erlend-aasland
Copy link
Contributor

Might it be that a similar fix needs to be applied to the following line:

cpython/configure.ac

Line 6265 in f497525

if test "$ac_sys_system" != "Darwin"; then

It seems to me like this check is equally broken.

Please open a new issue for this.

aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@sorcio @aisk
pythongh-111460: Restore ncurses widechar support on macOS (python#11…
1a9c29e 
…1878)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@sorcio @Glyphack
pythongh-111460: Restore ncurses widechar support on macOS (python#11…
63654b4 
…1878)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sorcio @erlend-aasland @corona10 @Turakar