Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-111835: Add seekable method to mmap.mmap #111852

Merged
merged 17 commits into from
Nov 9, 2023
Merged

gh-111835: Add seekable method to mmap.mmap #111852

merged 17 commits into from
Nov 9, 2023

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Nov 8, 2023 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Nov 8, 2023
Closed
@corona10
Copy link
Member Author

corona10 commented Nov 8, 2023 •
edited
Loading

@serhiy-storchaka cc @vstinner
As the issue reporter said, they can use seekable by subclassing mmap itself.
But this change definitely helpful to people who need to use library which checks that the file object supports seekable() method.
(I don't want to say it must be added but it is good to be added)

vstinner
vstinner approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Doc/library/mmap.rst Outdated Show resolved Hide resolved
@serhiy-storchaka
Copy link
Member

mmap.seek() always return None. It can make mmap not appropriate substitution for files. Adding seekable() method can break existing code.

@corona10 corona10 mentioned this pull request Nov 8, 2023
Closed
@corona10
Copy link
Member Author

corona10 commented Nov 8, 2023

mmap.seek() always return None. It can make mmap not appropriate substitution for files. Adding seekable() method can break existing code.

I left a comment for this.
#111835 (comment)
But I'm not sure how it will break the user's code even if we update seek() to return the current position.
I can not guess how people are doing something with None value.

serhiy-storchaka
serhiy-storchaka reviewed Nov 9, 2023
View reviewed changes
Doc/library/mmap.rst Outdated Show resolved Hide resolved
Doc/whatsnew/3.13.rst Show resolved Hide resolved
Lib/test/test_mmap.py Outdated Show resolved Hide resolved
vstinner
vstinner reviewed Nov 9, 2023
View reviewed changes
Modules/mmapmodule.c Outdated Show resolved Hide resolved
vstinner
vstinner reviewed Nov 9, 2023
View reviewed changes
Doc/whatsnew/3.13.rst Outdated Show resolved Hide resolved
serhiy-storchaka
serhiy-storchaka approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vstinner
vstinner approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@corona10 corona10 merged commit 6046aec into python:main Nov 9, 2023
30 checks passed
@corona10
Copy link
Member Author

corona10 commented Nov 9, 2023

@serhiy-storchaka @vstinner
Thank you for the reviews!!

@corona10 corona10 deleted the gh-111835 branch November 9, 2023 11:13
@technillogue technillogue mentioned this pull request Jan 21, 2024
Closed
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@corona10 @aisk
pythongh-111835: Add seekable method to mmap.mmap (pythongh-111852)
3706873
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@corona10 @Glyphack
pythongh-111835: Add seekable method to mmap.mmap (pythongh-111852)
1ffbd09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corona10 @serhiy-storchaka @vstinner