Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-111485: Make BEFORE_WITH a uop #111812

Merged
merged 1 commit into from
Nov 7, 2023
Merged

GH-111485: Make BEFORE_WITH a uop #111812

merged 1 commit into from
Nov 7, 2023

Conversation

brandtbucher
Copy link
Member

@brandtbucher brandtbucher commented Nov 7, 2023 •
edited by bedevere-app bot
Loading

See #111540 (comment). I've tested that this works with uops enabled.

(Also, replace two calls to _PyObject_CallNoArgs with _PyObject_CallNoArgsTstate, since we have the tstate handy in the interpreter.)

@brandtbucher brandtbucher self-assigned this Nov 7, 2023
@bedevere-app bedevere-app bot mentioned this pull request Nov 3, 2023
Closed
@brandtbucher brandtbucher added performance Performance or resource usage skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Nov 7, 2023
gvanrossum
gvanrossum approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah.

@brandtbucher brandtbucher merged commit 3e99c9c into python:main Nov 7, 2023
34 checks passed
hugovk pushed a commit to hugovk/cpython that referenced this pull request Nov 8, 2023
@brandtbucher @hugovk
pythonGH-111485: Make BEFORE_WITH a uop (pythonGH-111812)
8134614
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@brandtbucher @aisk
pythonGH-111485: Make BEFORE_WITH a uop (pythonGH-111812)
111b0b7
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@brandtbucher @Glyphack
pythonGH-111485: Make BEFORE_WITH a uop (pythonGH-111812)
a51a7a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees

@brandtbucher brandtbucher

Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandtbucher @gvanrossum