Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-108082: Remove _PyErr_WriteUnraisableMsg() #111643

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Nov 2, 2023

Replace the remaining calls with PyErr_FormatUnraisable().

Replace the remaining calls with PyErr_FormatUnraisable().
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I only looked at C changes, I didn't review the tests changes.

@serhiy-storchaka serhiy-storchaka merged commit 26c0e5e into python:main Nov 3, 2023
32 of 33 checks passed
@serhiy-storchaka serhiy-storchaka deleted the capi-remove-_PyErr_WriteUnraisableMsg branch November 3, 2023 07:45
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
Replace the remaining calls with PyErr_FormatUnraisable().
vstinner added a commit to vstinner/cffi that referenced this pull request Nov 15, 2023
Use the new public PyErr_FormatUnraisable() on Python 3.13.

The private _PyErr_WriteUnraisableMsg() function was removed in
Python 3.13:
python/cpython#111643
vstinner added a commit to vstinner/cffi that referenced this pull request Nov 15, 2023
Use the new public PyErr_FormatUnraisable() on Python 3.13.

The private _PyErr_WriteUnraisableMsg() function was removed in
Python 3.13:
python/cpython#111643
@vstinner
Copy link
Member

cffi uses the private _PyErr_WriteUnraisableMsg() removed in Python 3.13. I wrote python-cffi/cffi#34 to update the code to the public PyErr_FormatUnraisable() function.

vstinner added a commit to vstinner/cffi that referenced this pull request Nov 15, 2023
Use the new public PyErr_FormatUnraisable() on Python 3.13.

The private _PyErr_WriteUnraisableMsg() function was removed in
Python 3.13:
python/cpython#111643
arigo pushed a commit to python-cffi/cffi that referenced this pull request Nov 16, 2023
Use the new public PyErr_FormatUnraisable() on Python 3.13.

The private _PyErr_WriteUnraisableMsg() function was removed in
Python 3.13:
python/cpython#111643
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Replace the remaining calls with PyErr_FormatUnraisable().
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Replace the remaining calls with PyErr_FormatUnraisable().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants