gh-108082: Use PyErr_FormatUnraisable() #111580
Merged
+83
−114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace most of calls of _PyErr_WriteUnraisableMsg() and some calls of PyErr_WriteUnraisable(NULL) with PyErr_FormatUnraisable().
serhiy-storchaka
requested review from
pablogsal,
kumaraditya303,
markshannon,
iritkatriel and
methane
as code owners
vstinner
reviewed
Nov 1, 2023
Modules/gcmodule.c
Outdated
| @@ -1032,8 +1032,8 @@ delete_garbage(PyThreadState *tstate, GCState *gcstate, | |||
| Py_INCREF(op); | |||
| (void) clear(op); | |||
| if (_PyErr_Occurred(tstate)) { | |||
| _PyErr_WriteUnraisableMsg("in tp_clear of", | |||
| (PyObject*)Py_TYPE(op)); | |||
| PyErr_FormatUnraisable("Exception ignored in tp_clear of %.200s", | |||
There was a problem hiding this comment.
IMO %.200s is a bug here. We should no longer truncate type names if they are too long. Many years ago, Python had an internal buffer of a fixed size and so the overall string must not be too long. But this has been fixed.
Please don't truncate type names.
Objects/moduleobject.c
Outdated
Comment on lines
905
to
907
| PyErr_FormatUnraisable("Exception ignored in m_clear of module%s%V\n", | ||
| m->md_name ? " " : "", | ||
| m->md_name, ""); |
There was a problem hiding this comment.
Suggested change
| PyErr_FormatUnraisable("Exception ignored in m_clear of module%s%V\n", | |
| m->md_name ? " " : "", | |
| m->md_name, ""); | |
| PyErr_FormatUnraisable("Exception ignored in m_clear of module%s%V", | |
| m->md_name ? " " : "", | |
| m->md_name); |
Objects/typeobject.c
Outdated
| @@ -828,7 +828,7 @@ PyType_Modified(PyTypeObject *type) | |||
| if (bits & 1) { | |||
| PyType_WatchCallback cb = interp->type_watchers[i]; | |||
| if (cb && (cb(type) < 0)) { | |||
| PyErr_WriteUnraisable((PyObject *)type); | |||
| PyErr_FormatUnraisable("Exception ignored in watcher callback for %R", i, type); | |||
There was a problem hiding this comment.
If you want to log i variable, you should add %i somewhere.
vstinner
approved these changes
Nov 1, 2023
| PyErr_WriteUnraisable(NULL); | ||
| PyErr_FormatUnraisable("Exception ignored in m_clear of module%s%V", | ||
| m->md_name ? " " : "", | ||
| m->md_name, ""); |
There was a problem hiding this comment.
The last "" is not used, it can be removed.
Co-authored-by: Victor Stinner <[email protected]>
|
|
I wanted to do this change for many years. It's awful to get a warning without any context :-( Thanks for this nice enhancement! I like PyErr_FormatUnraisable() API! |
|
We both wanted it. But other tasks had higher priorities. |
FullteaR
pushed a commit
to FullteaR/cpython
that referenced
this pull request
Nov 3, 2023
Replace most of calls of _PyErr_WriteUnraisableMsg() and some calls of PyErr_WriteUnraisable(NULL) with PyErr_FormatUnraisable(). Co-authored-by: Victor Stinner <[email protected]>
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Replace most of calls of _PyErr_WriteUnraisableMsg() and some calls of PyErr_WriteUnraisable(NULL) with PyErr_FormatUnraisable(). Co-authored-by: Victor Stinner <[email protected]>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Replace most of calls of _PyErr_WriteUnraisableMsg() and some calls of PyErr_WriteUnraisable(NULL) with PyErr_FormatUnraisable(). Co-authored-by: Victor Stinner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace most of calls of _PyErr_WriteUnraisableMsg() and some calls of PyErr_WriteUnraisable(NULL) with PyErr_FormatUnraisable().