Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.12] Bump test deps: ruff and mypy (GH-111288) #111313

Merged
merged 1 commit into from
Oct 25, 2023
Merged

[3.12] Bump test deps: ruff and mypy (GH-111288) #111313

merged 1 commit into from
Oct 25, 2023

Conversation

art3xa
Copy link
Contributor

@art3xa art3xa commented Oct 25, 2023

(cherry picked from commit 0d1cbff)

3.12 does not have Tools/requirements-dev.txt but have Tools/clinic/requirements-dev.txt

(backport to #111288)

@bedevere-app bedevere-app bot mentioned this pull request Oct 25, 2023
Merged
AlexWaygood
AlexWaygood approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AlexWaygood AlexWaygood enabled auto-merge (squash) October 25, 2023 10:32
@AlexWaygood AlexWaygood merged commit 5e94556 into python:3.12 Oct 25, 2023
28 checks passed
@sobolevn
Copy link
Member

sobolevn commented Oct 25, 2023 •
edited
Loading

I think that we should sync the requirements file in 3.12 branch, otherwise, we would have all PRs like that.

@AlexWaygood
Copy link
Member

I think that we should sync the requirements file in 3.12 branch, otherwise, we would have all PRs like that.

As in, move the mypy pin from Tools/clinic/requirements-dev.txt to Tools/requirements-dev.txt in the 3.12 branch? Sure, I'd accept a PR doing that!

@art3xa
Copy link
Contributor Author

art3xa commented Oct 25, 2023

I think that we should sync the requirements file in 3.12 branch, otherwise, we would have all PRs like that.

As in, move the mypy pin from Tools/clinic/requirements-dev.txt to Tools/requirements-dev.txt in the 3.12 branch? Sure, I'd accept a PR doing that!

Yeah, I'll do it.

@art3xa art3xa mentioned this pull request Oct 25, 2023
Merged
@bedevere-app
Copy link

bedevere-app bot commented Oct 25, 2023

GH-111317 is a backport of this pull request to the 3.12 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@art3xa @sobolevn @AlexWaygood