bpo-35455: Fix thread_time for Solaris OS

[kulikjak]

Implementation of time.thread_time() doesn't work on Solaris because clock_id CLOCK_THREAD_CPUTIME_ID is not known (it is defined, but clock_gettime() returns EINVAL error). Solaris, however, has function gethrvtime() which can substitute this functionality.

https://bugs.python.org/issue35455

[auvipy]

skip news?

[kulikjak]

Well, since I created this pull request, clock_gettime(CLOCK_THREAD_CPUTIME_ID, ..) was implemented into the Solaris kernel, so I guess that this is no longer relevant.

[kulikjak]

Comment from https://bugs.python.org/issue42173#msg380205 confirmed that this issue is still relevant to Illumos based systems.

[terryjreedy]

When making such a mistake, please remove review requests as messages go out to all sent requests.
But good to see action on Solaris.

@auvipy Behavior bug fixes get NEWS items.

[kulikjak]

When making such a mistake, please remove review requests as messages go out to all sent requests.
But good to see action on Solaris.

@auvipy Behavior bug fixes get NEWS items.

I wanted to do so, but I don't believe that I have the necessary permissions to do so. Thank you for doing so.

[pablogsal]

Thanks for the PR @kulikjak !

[terryjreedy]

Fork owners and hence authors of PRs based on forks can do anything they want. The easiest way to add a news item to a PR developed from a local clone is to locally install and use blurb. The merging coredev may revise anyway.

[miss-islington]

Thanks @kulikjak for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

[miss-islington]

Thanks @kulikjak for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

[miss-islington]

Sorry @kulikjak and @pablogsal, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 9568622c9983b682b2a2a7bacfd3c341028ea099 3.9

[miss-islington]

Sorry, @kulikjak and @pablogsal, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 9568622c9983b682b2a2a7bacfd3c341028ea099 3.8

[miss-islington]

Thanks @kulikjak for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

[bedevere-bot]

GH-23130 is a backport of this pull request to the 3.9 branch.

[terryjreedy]

@kulikjak Do you know how to make backport PRs? For 3.8 in this case?

[bedevere-bot]

GH-23145 is a backport of this pull request to the 3.8 branch.

[bedevere-bot]

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL8 3.9 has failed when building commit 72bb4c6.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/250/builds/114) and take a look at the build logs.
4. Check if the failure is related to this commit (72bb4c6) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/250/builds/114

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

411 tests OK.

10 slowest tests:

• test_concurrent_futures: 3 min 48 sec
• test_tokenize: 2 min 41 sec
• test_unparse: 2 min 31 sec
• test_gdb: 2 min 15 sec
• test_capi: 2 min 3 sec
• test_multiprocessing_spawn: 2 min 2 sec
• test_peg_generator: 1 min 55 sec
• test_lib2to3: 1 min 37 sec
• test_asyncio: 1 min 31 sec
• test_unicodedata: 1 min 28 sec

1 test altered the execution environment:
test_asyncio

13 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_ossaudiodev
test_startfile test_tix test_tk test_ttk_guionly test_winconsoleio
test_winreg test_winsound test_zipfile64

Total duration: 5 min 31 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/asyncio/sslproto.py", line 321, in __del__
    self.close()
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/asyncio/sslproto.py", line 316, in close
    self._ssl_protocol._start_shutdown()
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/asyncio/sslproto.py", line 590, in _start_shutdown
    self._abort()
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/asyncio/sslproto.py", line 731, in _abort
    self._transport.abort()
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/asyncio/selector_events.py", line 680, in abort
    self._force_close(None)
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/asyncio/selector_events.py", line 731, in _force_close
    self._loop.call_soon(self._call_connection_lost, exc)
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/asyncio/base_events.py", line 746, in call_soon
    self._check_closed()
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/asyncio/base_events.py", line 510, in _check_closed
    raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed