Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-110950: add upstream Tk fixes to macOS installer. #111041

Merged
merged 6 commits into from
Nov 21, 2023
Merged

gh-110950: add upstream Tk fixes to macOS installer. #111041

merged 6 commits into from
Nov 21, 2023

Conversation

chrstphrchvz
Copy link
Contributor

@chrstphrchvz chrstphrchvz commented Oct 18, 2023 •
edited by bedevere-app bot
Loading

@chrstphrchvz chrstphrchvz requested a review from a team as a code owner October 18, 2023 17:32
@bedevere-app bedevere-app bot mentioned this pull request Oct 18, 2023
Closed
@chrstphrchvz
Copy link
Contributor Author

As with #108693 and #108806, I have not already attempted to build the macOS installer myself.

@ned-deily ned-deily changed the title gh-110950: add upstream fix to macOS installer gh-110950: add upstream Tk fixes to macOS installer. Nov 21, 2023
@ned-deily ned-deily merged commit d67f947 into python:main Nov 21, 2023
29 checks passed
@miss-islington-app
Copy link

Thanks @chrstphrchvz for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @chrstphrchvz for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 21, 2023
@chrstphrchvz @ned-deily @miss-islington
pythongh-110950: add upstream Tk fixes to macOS installer. (pythonGH-…
79e822d 
…111041)

Add upstream Tk patches for three problems affecting tkinter users:

- Update macOS installer to include a fix accepted by upstream Tcl/Tk
for a crash encountered after the first :meth:`tkinter.Tk` instance
is destroyed. (pythongh-92603)

- Update macOS installer to include an upstream Tcl/Tk fix
for the ``ttk::ThemeChanged`` error encountered in Tkinter. (pythongh-71383)

- Update macOS installer to include an upstream Tcl/Tk fix for the
``Secure coding is not enabled for restorable state!`` warning
encountered in Tkinter on macOS 14 Sonoma. (pythongh-110950)

(cherry picked from commit d67f947)

Co-authored-by: Christopher Chavez <[email protected]>
Co-authored-by: Ned Deily <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 21, 2023

GH-112293 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 21, 2023
@chrstphrchvz @ned-deily @miss-islington
pythongh-110950: add upstream Tk fixes to macOS installer. (pythonGH-…
d641520 
…111041)

Add upstream Tk patches for three problems affecting tkinter users:

- Update macOS installer to include a fix accepted by upstream Tcl/Tk
for a crash encountered after the first :meth:`tkinter.Tk` instance
is destroyed. (pythongh-92603)

- Update macOS installer to include an upstream Tcl/Tk fix
for the ``ttk::ThemeChanged`` error encountered in Tkinter. (pythongh-71383)

- Update macOS installer to include an upstream Tcl/Tk fix for the
``Secure coding is not enabled for restorable state!`` warning
encountered in Tkinter on macOS 14 Sonoma. (pythongh-110950)

(cherry picked from commit d67f947)

Co-authored-by: Christopher Chavez <[email protected]>
Co-authored-by: Ned Deily <[email protected]>
@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Nov 21, 2023
@bedevere-app
Copy link

bedevere-app bot commented Nov 21, 2023

GH-112294 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Nov 21, 2023
@chrstphrchvz chrstphrchvz deleted the patch-gh110950 branch November 21, 2023 08:20
This was referenced Nov 21, 2023
Closed
Closed
ned-deily added a commit that referenced this pull request Nov 21, 2023
@miss-islington @chrstphrchvz @ned-deily
[3.11] gh-110950: add upstream Tk fixes to macOS installer. (GH-111041)…
253ad78 
… (#112293)

Add upstream Tk patches for three problems affecting tkinter users:

- Update macOS installer to include a fix accepted by upstream Tcl/Tk
for a crash encountered after the first :meth:`tkinter.Tk` instance
is destroyed. (gh-92603)

- Update macOS installer to include an upstream Tcl/Tk fix
for the ``ttk::ThemeChanged`` error encountered in Tkinter. (gh-71383)

- Update macOS installer to include an upstream Tcl/Tk fix for the
``Secure coding is not enabled for restorable state!`` warning
encountered in Tkinter on macOS 14 Sonoma. (gh-110950)

(cherry picked from commit d67f947)

Co-authored-by: Christopher Chavez <[email protected]>
Co-authored-by: Ned Deily <[email protected]>
ned-deily added a commit that referenced this pull request Nov 21, 2023
@miss-islington @chrstphrchvz @ned-deily
[3.12] gh-110950: add upstream Tk fixes to macOS installer. (GH-111041)…
fab9824 
… (#112294)

Add upstream Tk patches for three problems affecting tkinter users:

- Update macOS installer to include a fix accepted by upstream Tcl/Tk
for a crash encountered after the first :meth:`tkinter.Tk` instance
is destroyed. (gh-92603)

- Update macOS installer to include an upstream Tcl/Tk fix
for the ``ttk::ThemeChanged`` error encountered in Tkinter. (gh-71383)

- Update macOS installer to include an upstream Tcl/Tk fix for the
``Secure coding is not enabled for restorable state!`` warning
encountered in Tkinter on macOS 14 Sonoma. (gh-110950)

(cherry picked from commit d67f947)

Co-authored-by: Christopher Chavez <[email protected]>
Co-authored-by: Ned Deily <[email protected]>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@chrstphrchvz @ned-deily @aisk
pythongh-110950: add upstream Tk fixes to macOS installer. (pythonGH-…
19c76ff 
…111041)

Add upstream Tk patches for three problems affecting tkinter users:

- Update macOS installer to include a fix accepted by upstream Tcl/Tk
for a crash encountered after the first :meth:`tkinter.Tk` instance
is destroyed. (pythongh-92603)

- Update macOS installer to include an upstream Tcl/Tk fix
for the ``ttk::ThemeChanged`` error encountered in Tkinter. (pythongh-71383)

- Update macOS installer to include an upstream Tcl/Tk fix for the
``Secure coding is not enabled for restorable state!`` warning
encountered in Tkinter on macOS 14 Sonoma. (pythongh-110950)

Co-authored-by: Ned Deily <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@chrstphrchvz @ned-deily @Glyphack
pythongh-110950: add upstream Tk fixes to macOS installer. (pythonGH-…
95cecbd 
…111041)

Add upstream Tk patches for three problems affecting tkinter users:

- Update macOS installer to include a fix accepted by upstream Tcl/Tk
for a crash encountered after the first :meth:`tkinter.Tk` instance
is destroyed. (pythongh-92603)

- Update macOS installer to include an upstream Tcl/Tk fix
for the ``ttk::ThemeChanged`` error encountered in Tkinter. (pythongh-71383)

- Update macOS installer to include an upstream Tcl/Tk fix for the
``Secure coding is not enabled for restorable state!`` warning
encountered in Tkinter on macOS 14 Sonoma. (pythongh-110950)

Co-authored-by: Ned Deily <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ned-deily ned-deily ned-deily approved these changes

Assignees
No one assigned
Labels
OS-mac topic-tkinter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrstphrchvz @ned-deily @hugovk