Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-106765: Building python 3.11.x installer FAILS, launcher.wixproj c… #110566

Merged
merged 4 commits into from
Oct 9, 2023

Conversation

ashish-2022
Copy link
Contributor

gh-106765: Building python 3.11.x installer FAILS, launcher.wixproj cannot detect v143 buildtools - Build documentation updated

@ashish-2022 ashish-2022 requested a review from a team as a code owner October 9, 2023 13:49
@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Oct 9, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Oct 9, 2023

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-app
Copy link

bedevere-app bot commented Oct 9, 2023

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-app
Copy link

bedevere-app bot commented Oct 9, 2023

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@zooba zooba added the skip news label Oct 9, 2023
@zooba
Copy link
Member

zooba commented Oct 9, 2023

You won't need a NEWS file for this change. Feel free to delete it (it's what is currently breaking your build)

…-106765.zrjpdz.rst

Deleting news file as it is not required.
@ashish-2022 ashish-2022 marked this pull request as ready for review October 9, 2023 16:30
@zooba zooba merged commit 0050670 into python:main Oct 9, 2023
25 checks passed
@zooba
Copy link
Member

zooba commented Oct 9, 2023

Thanks!

@ashish-2022
Copy link
Contributor Author

Thanks Steve.

@ashish-2022 ashish-2022 deleted the fix-win64-build-tools branch October 12, 2023 05:30
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants