Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Add the time to the HTML last updated format #110091

Merged
merged 7 commits into from
Nov 15, 2023
Merged

Docs: Add the time to the HTML last updated format #110091

merged 7 commits into from
Nov 15, 2023

Conversation

AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Sep 29, 2023 •
edited by github-actions bot
Loading

@AA-Turner AA-Turner added docs Documentation in the Doc dir skip issue skip news needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Sep 29, 2023
@AA-Turner AA-Turner mentioned this pull request Sep 29, 2023
Closed
vstinner
vstinner approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for today that.

... Do you have access to the timezone?

@vstinner
Copy link
Member

If you have no timezone information, can we use UTC timestamp?

@vstinner
Copy link
Member

Is it UTC?

https://github.com/sphinx-doc/sphinx/blob/b9c85984d2f4863e4c09932c746d915e3233507b/sphinx/util/i18n.py#L192-L199

vstinner
vstinner reviewed Sep 29, 2023
View reviewed changes
Doc/conf.py Outdated Show resolved Hide resolved
@AA-Turner @vstinner
Add the timezone
8559481 
Co-authored-by: Victor Stinner <[email protected]>
vstinner
vstinner approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, even better with the timezone :-)

@hugovk
Copy link
Member

hugovk commented Sep 29, 2023

👍

image

hugovk
hugovk requested changes Sep 29, 2023
View reviewed changes
Doc/conf.py Outdated Show resolved Hide resolved
vstinner
vstinner reviewed Sep 29, 2023
View reviewed changes
Doc/conf.py Outdated Show resolved Hide resolved
hugovk
hugovk reviewed Sep 30, 2023
View reviewed changes
Doc/conf.py Outdated Show resolved Hide resolved
@AA-Turner
Copy link
Member Author

Now:

image

A

@AA-Turner AA-Turner requested a review from hugovk October 18, 2023 09:42
hugovk
hugovk approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good:

image

Non-blocking:

I'd still prefer "UTC" instead of "GMT", strictly speaking they're not the same: GMT is a timezone used by some countries, UTC is the standard. And UTC is maybe better known, judging by Google results (GMT: "About 527 000 000 results", UTC: "About 2 550 000 000 results").

vstinner
vstinner approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner
Copy link
Member

Ah right, UTC is better. time.gmtime() is documented to return time in UTC timezone: https://docs.python.org/dev/library/time.html#time.gmtime

vstinner
vstinner reviewed Nov 15, 2023
View reviewed changes
Doc/conf.py Outdated Show resolved Hide resolved
@vstinner vstinner enabled auto-merge (squash) November 15, 2023 03:56
@vstinner vstinner merged commit 6c214de into python:main Nov 15, 2023
23 checks passed
@miss-islington-app
Copy link

Thanks @AA-Turner for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 15, 2023
@AA-Turner @miss-islington
Docs: Add the time to the HTML last updated format (pythonGH-110091)
58589b8 
(cherry picked from commit 6c214de)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 15, 2023

GH-112102 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Nov 15, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 15, 2023
@AA-Turner @miss-islington
Docs: Add the time to the HTML last updated format (pythonGH-110091)
5a65d25 
(cherry picked from commit 6c214de)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 15, 2023

GH-112103 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Nov 15, 2023
vstinner pushed a commit that referenced this pull request Nov 15, 2023
@miss-islington @AA-Turner
[3.12] Docs: Add the time to the HTML last updated format (GH-110091) (…
c190552 
…#112102)

Docs: Add the time to the HTML last updated format (GH-110091)
(cherry picked from commit 6c214de)

Co-authored-by: Adam Turner <[email protected]>
vstinner pushed a commit that referenced this pull request Nov 15, 2023
@miss-islington @AA-Turner
[3.11] Docs: Add the time to the HTML last updated format (GH-110091) (…
a92b9e5 
…#112103)

Docs: Add the time to the HTML last updated format (GH-110091)
(cherry picked from commit 6c214de)

Co-authored-by: Adam Turner <[email protected]>
@vstinner
Copy link
Member

I need this feature. I never understand if https://docs.python.org/dev/ was updated or not. So I merged the PR.

Thanks @AA-Turner for this nice enhancement!

aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@AA-Turner @aisk
Docs: Add the time to the HTML last updated format (python#110091)
4d2f252
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@AA-Turner @Glyphack
Docs: Add the time to the HTML last updated format (python#110091)
90fc443
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AA-Turner @vstinner @hugovk