Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-109329: Support for basic pystats for Tier 2 #109913

Merged
merged 17 commits into from
Oct 4, 2023
Merged

gh-109329: Support for basic pystats for Tier 2 #109913

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
7ba5f55
gh-109329: Support for basic pystats for Tier 2
mdboom Sep 26, 2023
b84f496
Remove unnecessary stuff
mdboom Sep 26, 2023
5549410
Delete trailing whitespace
mdboom Sep 26, 2023
ed639fc
Don't print optimization stats if not in dataset
mdboom Sep 26, 2023
195664e
Fix logic
mdboom Sep 26, 2023
8d76c0a
More simple Tier 2 counters
mdboom Sep 27, 2023
c54707a
Renames and fixups
mdboom Sep 27, 2023
ba58546
Lots more stats
mdboom Sep 27, 2023
08cd8c0
Disable Tier 1 stats in Tier 2
mdboom Sep 27, 2023
8d2699d
Trailing whitespace
mdboom Sep 27, 2023
ad0ca42
Make histogram bias more explicit
mdboom Sep 28, 2023
e5ee4e5
Various simplifications from code review
mdboom Sep 28, 2023
0dac9e5
Bugfix getting opcode stats
mdboom Oct 2, 2023
69a6e7b
Change bucketing. Change how execution length is calculated
mdboom Oct 2, 2023
d7c1403
Clamp lower range of histogram as well
mdboom Oct 3, 2023
aa69c0f
Fix divide-by-zero
mdboom Oct 3, 2023
5c3599a
Merge branch 'main' into tier2-stats
mdboom Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unnecessary stuff
  • Loading branch information
@mdboom
mdboom committed Sep 26, 2023
commit b84f496e3b2b8616eb696f51cfc78e54412ea5d5
1 change: 0 additions & 1 deletion Include/cpython/pystats.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ typedef struct _gc_stats {

typedef struct _uop_stats {
uint64_t execution_count;
uint64_t miss;
} UOpStats;

typedef struct _optimization_stats {
Expand Down
2 changes: 0 additions & 2 deletions Include/internal/pycore_code.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,6 @@ extern int _PyStaticCode_Init(PyCodeObject *co);
#define GC_STAT_ADD(gen, name, n) do { if (_Py_stats) _Py_stats->gc_stats[(gen)].name += (n); } while (0)
#define OPTIMIZATION_STAT_INC(name) do { if (_Py_stats) _Py_stats->optimization_stats.name++; } while (0)
#define UOP_EXE_INC(opname) do { if (_Py_stats) _Py_stats->optimization_stats.opcode[opname].execution_count++; } while (0)
#define UOP_STAT_INC(opname, name) do { if (_Py_stats) _Py_stats->optimization_stats.opcode[opname].name++; } while (0)

// Export for '_opcode' shared extension
PyAPI_FUNC(PyObject*) _Py_GetSpecializationStats(void);
Expand All @@ -301,7 +300,6 @@ PyAPI_FUNC(PyObject*) _Py_GetSpecializationStats(void);
#define GC_STAT_ADD(gen, name, n) ((void)0)
#define OPTIMIZATION_STAT_INC(name) ((void)0)
#define UOP_EXE_INC(opname) ((void)0)
#define UOP_STAT_INC(opname, name) ((void)0)
#endif // !Py_STATS

// Utility functions for reading/writing 32/64-bit values in the inline caches.
Expand Down