Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-109408: Remove Ubuntu unit tests from Azure Pipelines #109452

Merged
merged 4 commits into from
Sep 17, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Sep 15, 2023

Both ci.yml and pr.yml run Ubuntu_CI_Tests which runs .azure-pipelines/posix-steps.yml

.azure-pipelines/posix-steps.yml does:

  1. checkout/setup
  2. build Python
  3. display build info
  4. run unit tests
  5. run patchcheck (PR only)
  6. report unit test results

This PR removes the Ubuntu unit test run (4)/report (6), as we're running it on GitHub Actions.

Because patchcheck is only run for PRs (pr.yml), there's no point building Python and then doing nothing for ci.yml, so we can remove the whole Ubuntu_CI_Tests from ci.yml.

Finally, rename Ubuntu_CI_Tests to something more accurate: Ubuntu_Patchcheck.

This speeds up Ubunutu part of pr.yml from ~14 to ~4 mins, and ci.yml from ~14 to 0 mins.

Copy link
Contributor

@itamaro itamaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@hugovk hugovk merged commit a75daed into python:main Sep 17, 2023
26 of 27 checks passed
@hugovk hugovk deleted the ap-rm-ubuntu-tests branch September 17, 2023 17:46
@miss-islington
Copy link
Contributor

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @hugovk, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a75daed7e004ee9a53b160307c4c072656176a02 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 17, 2023
@bedevere-app
Copy link

bedevere-app bot commented Sep 17, 2023

GH-109519 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Sep 17, 2023
@bedevere-app
Copy link

bedevere-app bot commented Sep 17, 2023

GH-109520 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Sep 17, 2023
hugovk added a commit to hugovk/cpython that referenced this pull request Sep 17, 2023
hugovk added a commit that referenced this pull request Sep 17, 2023
Yhg1s pushed a commit that referenced this pull request Sep 17, 2023
…09452) (#109519)

gh-109408: Remove Ubuntu unit tests from Azure Pipelines (GH-109452)
(cherry picked from commit a75daed)

Co-authored-by: Hugo van Kemenade <[email protected]>
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants