gh-56166: Deprecate passing counts and maxsplit via position in re #107767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a very common mistake, see #99918 (comment) |
hauntsaninja
changed the title
|
Thank you for your PR @hauntsaninja, but there is a different solution to a problem with signature. Also, these parameters are not keyword-only yet, so they should not be documented so. Instead the deprecation of passing the corresponding arguments positionally should be documented. I created a different PR #107778. |
|
Since the other patch passed all checks, I am assuming that inspect.signature will continue to display '0' rather than'_zero_sentinal', so that the IDLE tests should continue as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch authored by @serhiy-storchaka