Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35240: Add "doctest" job to Travis CI #10753

Merged
merged 1 commit into from
Nov 28, 2018
Merged

bpo-35240: Add "doctest" job to Travis CI #10753

merged 1 commit into from
Nov 28, 2018

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Nov 27, 2018 •
edited by bedevere-bot
Loading

Create a new "doctest" job in Travis CI to run "make doctest".

https://bugs.python.org/issue35240

@vstinner vstinner mentioned this pull request Nov 27, 2018
Closed
@vstinner
Copy link
Member Author

This change:

  • make the "cpython" job faster, since it doesn't run "make -C Doc venv doctest" anymore which takes 1 minute
  • "make doctest" is now run in parallel
  • "make doctest" is now run with a Python compiled in release mode

@vstinner
bpo-35240: Add "doctest" job to Travis CI
95ab3f6 
Create a new "doctest" job in Travis CI to run "make doctest".
zware
zware approved these changes Nov 28, 2018
View reviewed changes
Copy link
Member

@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This should hopefully make things more stable as well.

@matrixise
Copy link
Member

Just one question, why do you specify make -j4, do we have a quadcore?

@vstinner
Copy link
Member Author

@matrixise: last time I checked, Travis CI announced more than 90 cores. Check "pythoninfo" in Travis CI.

@vstinner vstinner merged commit a22df48 into python:master Nov 28, 2018
@vstinner vstinner deleted the doctest_job branch November 30, 2018 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zware zware zware approved these changes

@JulienPalard JulienPalard Awaiting requested review from JulienPalard

@brettcannon brettcannon Awaiting requested review from brettcannon

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vstinner @matrixise @zware @the-knights-who-say-ni @bedevere-bot