Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-105481: do not auto-generate pycore_intrinsics.h #106913

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Jul 20, 2023

pycore_intrinsics.h is currently auto-generated by the build script, which adds complications to the build process but doesn't really buy us anything. This PR defines them in C and exposes through a method in the _opcode module. There are two places where the list of intrinsics is defined before and after this change.

@iritkatriel iritkatriel added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jul 20, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit ef8c521 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jul 20, 2023
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the process for adding a new intrinsic is now just to add a line to the appropriate table and add a define to pycore_intrinsics.h and update the MAX define there? That's not too tedious.

@iritkatriel
Copy link
Member Author

Some of the refleaks failures look like this:

======================================================================
FAIL: test_extended_arg (test.test_capi.test_misc.TestUops.test_extended_arg)
Check EXTENDED_ARG handling in superblock creation
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/test/test_capi/test_misc.py", line 2491, in test_extended_arg
    self.assertIsNone(ex)
AssertionError: <uop_executor object at 0x1c24a50> is not None
----------------------------------------------------------------------

@iritkatriel iritkatriel merged commit 9c81fc2 into python:main Jul 20, 2023
20 checks passed
@iritkatriel iritkatriel deleted the intrinsics branch July 25, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants