Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-102450: Add ISO-8601 alternative for midnight to fromisoformat() calls. #105856

Merged
merged 19 commits into from
Sep 25, 2024
Merged

gh-102450: Add ISO-8601 alternative for midnight to fromisoformat() calls. #105856

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
e57d1b6
Add NEWS.d entry
TizzySaurus Jun 16, 2023
9613a38
Merge branch 'main' of personal.github.com:TizzySaurus/cpython
TizzySaurus Mar 1, 2024
aa67832
Merge remote-tracking branch 'upstream/main'
TizzySaurus Sep 25, 2024
d711daf
Allow ISO-8601 24:00 alternative to midnight on datetime.time.fromiso…
TizzySaurus Jun 16, 2023
f32aa97
Allow ISO-8601 24:00 alternative to midnight on datetime.datetime.fro…
TizzySaurus Jun 16, 2023
d52bf41
Add NEWS.d entry
TizzySaurus Jun 16, 2023
699dfcb
Improve error message when hour is 24 and minute/second/microsecond i…
TizzySaurus Jun 16, 2023
6e46433
Add tests for 24:00 fromisoformat
TizzySaurus Jun 17, 2023
040da2c
Remove duplicate call to days_in_month() by storing in variable
TizzySaurus Jun 17, 2023
4833d68
Add Python implementation
TizzySaurus Jun 17, 2023
c71764f
Fix Lint
TizzySaurus Jun 17, 2023
0b92a1c
Fix differing error msg in datetime.fromisoformat implementations whe…
TizzySaurus Jun 17, 2023
c9db98b
Fix using time components inside tzinfo in Python implementation
TizzySaurus Jun 18, 2023
004a5ff
Don't parse tzinfo in C implementation when invalid iso midnight
TizzySaurus Jun 18, 2023
f182e2e
Remove duplicated variable in datetime test assertion line
TizzySaurus Jun 18, 2023
1b65671
Add self to acknowledgements
TizzySaurus Sep 25, 2024
ae85372
Remove duplicate NEWS entry
TizzySaurus Sep 25, 2024
9d02f82
Linting
TizzySaurus Sep 25, 2024
2ccb2a2
Add missing test case for when wrapping the year makes it invalid (to…
TizzySaurus Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add missing test case for when wrapping the year makes it invalid (to… 
…o large)
  • Loading branch information
@TizzySaurus
TizzySaurus committed Sep 25, 2024
commit 2ccb2a220c4e60d3fccbc2e3feab9796fd3b9d2e
1 change: 1 addition & 0 deletions Lib/test/datetimetester.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3386,6 +3386,7 @@ def test_fromisoformat_fails_datetime(self):
'2009-04-19T24:01:00.000000', # Has non-zero minutes on 24:00
'2009-04-32T24:00:00.000000', # Day is invalid before wrapping due to 24:00
'2009-13-01T24:00:00.000000', # Month is invalid before wrapping due to 24:00
TizzySaurus marked this conversation as resolved.
Show resolved Hide resolved
'9999-12-31T24:00:00.000000', # Year is invalid after wrapping due to 24:00
]

for bad_str in bad_strs:
Expand Down
Loading