gh-104106: Add gcc fallback of mkfifoat/mknodat for macOS #104129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
corona10
commented
May 3, 2023
•
corona10
commented
- Issue: Python 3.11 is unbuildable with GCC on macOS (error: 'HAVE_MKFIFOAT_RUNTIME' undeclared, error: 'HAVE_MKNODAT_RUNTIME' undeclared) #104106
|
This patch contains a typo. |
Fix done :) |
biergaizi
added a commit
to biergaizi/prefix
that referenced
this pull request
May 5, 2023
Currently, dev-lang/python-3.11.3 is unbuildable on macOS due to GCC
incompatibility. There exists two "#ifdef" checks for the system calls
mkfifoat() and mknodat(), which are not compatible with GCC. Because
they're defined using the __builtin_available() function - specific to
clang without a fallback for GCC, they're never defined, thus creating
the following errors:
./Modules/posixmodule.c:15647:23: error: 'HAVE_MKFIFOAT_RUNTIME'
undeclared (first use in this function); did you mean
'HAVE_MKDIRAT_RUNTIME'?
./Modules/posixmodule.c:15651:22: error: 'HAVE_MKNODAT_RUNTIME'
undeclared (first use in this function); did you mean
'HAVE_MKDIRAT_RUNTIME'?
This bug [1] has already been reported to upstream with a patch [2]
waiting to be merged. This commit applies the upstream patch to add
the missing GCC fallbacks.
[1] python/cpython#104106
[2] python/cpython#104129
Closes: https://bugs.gentoo.org/905618
Signed-off-by: Yifeng Li <[email protected]>
|
Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
Sorry, @corona10, I could not cleanly backport this to |
corona10
added a commit
to corona10/cpython
that referenced
this pull request
May 5, 2023
pythongh-104129). (cherry picked from commit e5b8b19) Co-authored-by: Dong-hee Na <[email protected]>
corona10
added a commit
to corona10/cpython
that referenced
this pull request
May 5, 2023
|
GH-104187 is a backport of this pull request to the 3.11 branch. |
carljm
added a commit
to carljm/cpython
that referenced
this pull request
May 5, 2023
* main: (61 commits) pythongh-64595: Argument Clinic: Touch source file if any output file changed (python#104152) pythongh-64631: Test exception messages in cloned Argument Clinic funcs (python#104167) pythongh-68395: Avoid naming conflicts by mangling variable names in Argument Clinic (python#104065) pythongh-64658: Expand Argument Clinic return converter docs (python#104175) pythonGH-103092: port `_asyncio` freelist to module state (python#104196) pythongh-104051: fix crash in test_xxtestfuzz with -We (python#104052) pythongh-104190: fix ubsan crash (python#104191) pythongh-104106: Add gcc fallback of mkfifoat/mknodat for macOS (pythongh-104129) pythonGH-104142: Fix _Py_RefcntAdd to respect immortality (pythonGH-104143) pythongh-104112: link from cached_property docs to method-caching FAQ (python#104113) pythongh-68968: Correcting message display issue with assertEqual (python#103937) pythonGH-103899: Provide a hint when accidentally calling a module (pythonGH-103900) pythongh-103963: fix 'make regen-opcode' in out-of-tree builds (python#104177) pythongh-102500: Add PEP 688 and 698 to the 3.12 release highlights (python#104174) pythonGH-81079: Add case_sensitive argument to `pathlib.Path.glob()` (pythonGH-102710) pythongh-91896: Deprecate collections.abc.ByteString (python#102096) pythongh-99593: Add tests for Unicode C API (part 2) (python#99868) pythongh-102500: Document PEP 688 (python#102571) pythongh-102500: Implement PEP 688 (python#102521) pythongh-96534: socketmodule: support FreeBSD divert(4) socket (python#96536) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.