Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-103334: Ignore Tools/c-analyzer/cpython/_parser.py from patchcheck #103335

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Apr 7, 2023

I've also added a small comment to Tools/c-analyzer/cpython/_parser.py to trigger the patchcheck CI. It must pass now.

Automerge-Triggered-By: GH:ericsnowcurrently

@sobolevn
Copy link
Member Author

sobolevn commented Apr 7, 2023

Are there any other files to ignore?

Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable. Ideally the reindent tool would ignore tabs in string literals, but that would be a messier change without much benefit.

@ericsnowcurrently
Copy link
Member

I'm not aware of any other files to ignore.

@sobolevn
Copy link
Member Author

sobolevn commented Apr 10, 2023

@ericsnowcurrently I guess this now can be merged, any new files can be added afterwards if needed. Thanks for the review!

@miss-islington
Copy link
Contributor

Status check is done, and it's a success ✅.

@miss-islington miss-islington merged commit 40db5c6 into python:main Apr 10, 2023
@ericsnowcurrently
Copy link
Member

Thanks, @sobolevn!

warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
…atchcheck` (pythonGH-103335)

I've also added a small comment to `Tools/c-analyzer/cpython/_parser.py` to trigger the `patchcheck` CI. It must pass now.

Automerge-Triggered-By: GH:ericsnowcurrently
aisk pushed a commit to aisk/cpython that referenced this pull request Apr 18, 2023
…atchcheck` (pythonGH-103335)

I've also added a small comment to `Tools/c-analyzer/cpython/_parser.py` to trigger the `patchcheck` CI. It must pass now.

Automerge-Triggered-By: GH:ericsnowcurrently
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants