GH-83162: Rename re.error for better clarity. #101677

achhina · 2023-02-08T05:58:16Z

Follow-up of rebased/squashed PR-1751 - renaming re.error for better clarity.

TODO

~~Settle on new exception name~~. We seem to have a consensus for PatternError.
~~Follow-up on whether we rename the exception in idlelib/replace.py~~. Approved for now.
~~Ask whether this should also be added Python 3.13 What's New~~. Added to Python 3.13 What's New.

Issue: better name for re.error Exception class. #83162

barneygale · 2023-02-08T15:00:03Z

Maybe it's just me, but I initially read ReCompileError as "recompile error", despite the capitalisation of the 'C'. Would PatternCompileError or just PatternError be any better?

achhina · 2023-02-09T05:18:13Z

Maybe it's just me, but I initially read ReCompileError as "recompile error", despite the capitalisation of the 'C'. Would PatternCompileError or just PatternError be any better?

Thanks for pointing that out, I agree that it can easily be read as recompile error. I think both PatternCompileError & PatternError would also work well, but I prefer RESyntaxError for some of the reasons I laid out in the original issue thread - where we should consolidate this discussion. However, happy to hear otherwise!

SylvainDe · 2023-04-01T18:32:09Z

Nice PR!
I'm not sure if this comment should be on the issue or on the PR but could we make the error name easier to read by using the ""full"" name "Regex" instead of "re".

hugovk

Ask whether this should also be added Python 3.12 What's New

Yes please, in the 3.13 one.

Doc/library/re.rst

Lib/re/_constants.py

…ility. Co-authored-by: Matthias Bussonnier <[email protected]>

achhina · 2023-05-29T00:10:49Z

Nice PR! I'm not sure if this comment should be on the issue or on the PR but could we make the error name easier to read by using the ""full"" name "Regex" instead of "re".

Thanks!

I like the idea of the module name being more precise, however, that would be a very disruptive change and not something that should be done in this PR without any further discussions. Feel free to create another issue/start a discussion over at discuss.python.org to see if you can get any momentum.

achhina · 2023-05-29T01:10:39Z

Yowza, I didn't expect this to happen.

Out of habit, I rebased instead of merging on upstream/main for new changes since the last time I touched this branch. That seems to have touched all the files and add all the module owners... sorry about that! I'll try to revert this, or might just close this PR and create a new one if I can't salvage it.

…Python 3.13 What's New.

achhina · 2023-05-29T01:27:01Z

Okay, a forced push to the previous commit seemed to fix that. Sorry I know that a force push is not recommended in cpythons workflow, but it seemed to be the easiest thing I could think of instead of trying to revert the previous rebase.

@hugovk I've added the exception renaming to the 3.13 What's New section, do you think I should change this PR from draft to review?

I can also continue the discussions for the new name for the exception in the original issue.

hugovk · 2023-05-30T10:30:40Z

Yes, I think think is ready for review.

Doc/whatsnew/3.13.rst

Misc/NEWS.d/next/Library/2023-02-08-00-43-29.gh-issue-83162.ufdI9F.rst

Co-authored-by: Hugo van Kemenade <[email protected]>

…dI9F.rst Co-authored-by: Hugo van Kemenade <[email protected]>

achhina · 2023-06-04T19:54:30Z

Yes, I think is ready for review.

Great, done, and fixed the Sphinx warnings. Just need to settle on the new exception name now.

terryjreedy

How did RESyntaxError suddenly become RECompileError, which I think is worse. Like Barney, I prefer PatternError. The error is in the pattern, not the compilation process.

The pattern in error naming is SomethingError. I dislike multiple capitals, as in JSONDecodeError. Any of JsonError, DecodeError, ever JsonDecodeError would have been better. RegexError would have been OK with me too, but that apparently was not considered.

bedevere-bot · 2023-06-04T22:27:38Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

achhina · 2023-06-04T22:34:16Z

How did RESyntaxError suddenly become RECompileError, which I think is worse.

This was the error message chosen in the original PR that was closed; I had not made any changes to it yet, as I wanted to get a consensus on the name first before going through the effort of renaming.

Like Barney, I prefer PatternError.

Got it, seems to be two votes for PatternError, so unless someone else says otherwise I'll rename it to that when I get some time.

Lib/re/_constants.py

bedevere-bot · 2023-06-07T09:53:00Z

Nobody expects the Spanish Inquisition!

@terryjreedy: please review the changes made to this pull request.

achhina · 2023-08-22T12:17:42Z

@terryjreedy would there be anything else that needs to be done here?

hugovk · 2023-08-22T12:30:26Z

Please could you resolve the merge conflict?

achhina · 2023-08-22T12:33:30Z

Sorry on mobile, will do later today.

achhina · 2023-08-27T20:43:31Z

Hi @hugovk, I've gone ahead and resolved the merge conflicts.

achhina · 2023-12-03T03:09:11Z

Hi, friendly ping @terryjreedy, would you mind taking another look at this PR?

Doc/library/re.rst

achhina · 2023-12-03T17:03:21Z

Thanks @hugovk, I've gone ahead and made the requested changes.

hugovk

Thank you!

Backport idlelib part of python#101677 with simple rename.

bedevere-app · 2023-12-12T03:05:19Z

GH-112987 is a backport of this pull request to the 3.12 branch.

Backport idlelib part of #101677 with simple rename.

…ythonGH-112987) Backport idlelib part of pythonGH-101677 with simple rename. (cherry picked from commit fd3b894) Co-authored-by: Terry Jan Reedy <[email protected]>

…2987) (#113013) Backport idlelib part of GH-101677 with simple rename. (cherry picked from commit fd3b894) Co-authored-by: Terry Jan Reedy <[email protected]>

Renamed re.error for clarity, and kept re.error for backward compatibility. Updated idlelib files at TJR's request. --------- Co-authored-by: Matthias Bussonnier <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]> Co-authored-by: Terry Jan Reedy <[email protected]>

bedevere-bot added the awaiting review label Feb 8, 2023

bedevere-bot mentioned this pull request Feb 8, 2023

better name for re.error Exception class. #83162

Closed

hugovk reviewed May 23, 2023

View reviewed changes

Doc/library/re.rst Outdated Show resolved Hide resolved

Lib/re/_constants.py Outdated Show resolved Hide resolved

hugovk added the 3.13 bugs and security fixes label May 23, 2023

achhina and others added 3 commits May 28, 2023 19:40

Renamed re.error for clarity, and kept re.error for backward compatib…

aa576a5

…ility. Co-authored-by: Matthias Bussonnier <[email protected]>

pythonGH-83162: Fix deprecated sre_compile to _compiler.

e72dce1

pythonGH-83162: Update _compiler and _constants to new exception name.

5274810

achhina force-pushed the GH-83162 branch from 03c8058 to 5274810 Compare May 29, 2023 01:15

Adding code review commit suggestions, and adding re.error rename to …

0eca4ac

…Python 3.13 What's New.

Fixed re.error to be a code directive instead of an exception directive.

db36a4a

hugovk reviewed May 30, 2023

View reviewed changes

Doc/whatsnew/3.13.rst Outdated Show resolved Hide resolved

Misc/NEWS.d/next/Library/2023-02-08-00-43-29.gh-issue-83162.ufdI9F.rst Outdated Show resolved Hide resolved

achhina and others added 3 commits June 4, 2023 15:48

Update Doc/whatsnew/3.13.rst

bc44d0f

Co-authored-by: Hugo van Kemenade <[email protected]>

Update Misc/NEWS.d/next/Library/2023-02-08-00-43-29.gh-issue-83162.uf…

a2a81b5

…dI9F.rst Co-authored-by: Hugo van Kemenade <[email protected]>

Merge branch 'main' into pythonGH-83162

d5e2c44

achhina marked this pull request as ready for review June 4, 2023 19:51

achhina requested a review from terryjreedy as a code owner June 4, 2023 19:51

terryjreedy requested changes Jun 4, 2023

View reviewed changes

bedevere-bot added awaiting changes and removed awaiting review labels Jun 4, 2023

terryjreedy reviewed Jun 4, 2023

View reviewed changes

Lib/re/_constants.py Outdated Show resolved Hide resolved

bedevere-bot added the awaiting change review label Jun 7, 2023

bedevere-bot requested a review from terryjreedy June 7, 2023 09:53

achhina added 2 commits August 27, 2023 15:56

pythonGH-83162: Resolved merge conflicts.

aac93f2

Merge remote-tracking branch 'upstream/main' into pythonGH-83162

b0d31d7

pythonGH-83162: Satisfy merge conflict.

72480cf

hugovk reviewed Dec 3, 2023

View reviewed changes

Doc/library/re.rst Outdated Show resolved Hide resolved

achhina added 2 commits December 3, 2023 11:58

pythonGH-83162: Unwrap paragraph.

1d3d472

pythonGH-83162: Add space back in.

f0a3cb0

achhina requested a review from hugovk December 3, 2023 17:09

hugovk approved these changes Dec 3, 2023

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting change review labels Dec 3, 2023

terryjreedy merged commit a01022a into python:main Dec 11, 2023
30 of 31 checks passed

bedevere-app bot removed the awaiting merge label Dec 11, 2023

terryjreedy added a commit to terryjreedy/cpython that referenced this pull request Dec 12, 2023

[3.12] pythongh-83162: Rename re.error in idlelib (python#101677)

eb8848c

Backport idlelib part of python#101677 with simple rename.

terryjreedy mentioned this pull request Dec 12, 2023

[3.12] gh-83162: Rename re.error in idlelib (GH-101677) #112987

Merged

terryjreedy added a commit that referenced this pull request Dec 12, 2023

[3.12] gh-83162: Rename re.error in idlelib (GH-101677) (#112987)

fd3b894

Backport idlelib part of #101677 with simple rename.

miss-islington mentioned this pull request Dec 12, 2023

[3.11] [3.12] gh-83162: Rename re.error in idlelib (GH-101677) (GH-112987) #113013

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GH-83162: Rename re.error for better clarity. #101677

GH-83162: Rename re.error for better clarity. #101677

achhina commented Feb 8, 2023 •

edited

Loading

barneygale commented Feb 8, 2023

achhina commented Feb 9, 2023

SylvainDe commented Apr 1, 2023

hugovk left a comment

achhina commented May 29, 2023

achhina commented May 29, 2023

achhina commented May 29, 2023

hugovk commented May 30, 2023

achhina commented Jun 4, 2023

terryjreedy left a comment •

edited

Loading

bedevere-bot commented Jun 4, 2023

achhina commented Jun 4, 2023

bedevere-bot commented Jun 7, 2023

achhina commented Aug 22, 2023

hugovk commented Aug 22, 2023

achhina commented Aug 22, 2023

achhina commented Aug 27, 2023

achhina commented Dec 3, 2023

achhina commented Dec 3, 2023

hugovk left a comment

bedevere-app bot commented Dec 12, 2023

GH-83162: Rename re.error for better clarity. #101677

GH-83162: Rename re.error for better clarity. #101677

Conversation

achhina commented Feb 8, 2023 • edited Loading

barneygale commented Feb 8, 2023

achhina commented Feb 9, 2023

SylvainDe commented Apr 1, 2023

hugovk left a comment

Choose a reason for hiding this comment

achhina commented May 29, 2023

achhina commented May 29, 2023

achhina commented May 29, 2023

hugovk commented May 30, 2023

achhina commented Jun 4, 2023

terryjreedy left a comment • edited Loading

Choose a reason for hiding this comment

bedevere-bot commented Jun 4, 2023

achhina commented Jun 4, 2023

bedevere-bot commented Jun 7, 2023

achhina commented Aug 22, 2023

hugovk commented Aug 22, 2023

achhina commented Aug 22, 2023

achhina commented Aug 27, 2023

achhina commented Dec 3, 2023

achhina commented Dec 3, 2023

hugovk left a comment

Choose a reason for hiding this comment

bedevere-app bot commented Dec 12, 2023

achhina commented Feb 8, 2023 •

edited

Loading

terryjreedy left a comment •

edited

Loading