Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-101112: Specify type of pattern for Path.rglob #101132

Merged
merged 1 commit into from
Jan 20, 2023
Merged

GH-101112: Specify type of pattern for Path.rglob #101132

merged 1 commit into from
Jan 20, 2023

Conversation

jugmac00
Copy link
Contributor

@jugmac00 jugmac00 commented Jan 18, 2023 •
edited by bedevere-bot
Loading

The documentation for rglob did not mention what pattern actually is.

Mentioning and linking to fnmatch makes this explicit, as the documentation for fnmatch both shows the syntax and some explanation.

@jugmac00
pythonGH-101112: Specify type of pattern for Path.rglob
69aae06 
The documentation for `rglob` did not mention what `pattern` actually
is.

Mentioning and linking to `fnmatch` makes this explicit, as the
documentation for `fnmatch` both shows the syntax and some explanation.
@bedevere-bot bedevere-bot mentioned this pull request Jan 18, 2023
Closed
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels Jan 18, 2023
@ambv ambv added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jan 20, 2023
@ambv ambv merged commit 61f338a into python:main Jan 20, 2023
@miss-islington
Copy link
Contributor

Thanks @jugmac00 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @jugmac00 and @ambv, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 61f338a005aa9f36b2a0a8d6924857e703bb6140 3.11

@miss-islington
Copy link
Contributor

Sorry @jugmac00 and @ambv, I had trouble checking out the 3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 61f338a005aa9f36b2a0a8d6924857e703bb6140 3.10

@jugmac00
Copy link
Contributor Author

@ambv my fault, I should have converted this pr into a draft after I received some valuable feedback on the related issue. While the merged content is not 100% correct, imho it is not that bad. I will prepare a follow-up pr tomorrow.

@ambv
Copy link
Contributor

ambv commented Jan 20, 2023

Oh, it wasn't clear to me the suggestions are meant to be part of this PR. Yeah, a follow up will be great, thanks.

@jugmac00 jugmac00 deleted the specify-rglob-pattern branch January 20, 2023 22:28
@jugmac00
Copy link
Contributor Author

@ambv As promised -> #101223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barneygale barneygale Awaiting requested review from barneygale barneygale is a code owner

Assignees

@ambv ambv

Labels
docs Documentation in the Doc dir needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jugmac00 @miss-islington @ambv @bedevere-bot