Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-100098: [Enum] insist on actual tuples, no subclasses, for auto #100099

Merged
merged 2 commits into from
Dec 8, 2022

Conversation

ethanfurman
Copy link
Member

@ethanfurman ethanfurman commented Dec 8, 2022

When checking for auto() instances, only top-level usage is supported, which means either alone or as part of a regular tuple. Other containers, such as lists, dicts, or namedtuples, are not supported.

When checking for auto() instances, only top-level usage is supported,
which means either alone or as part of a regular tuple. Other
containers, such as lists, dicts, or namedtuples, are not supported.
@ethanfurman ethanfurman added stdlib Python modules in the Lib dir 3.11 only security fixes 3.12 bugs and security fixes needs backport to 3.11 only security fixes labels Dec 8, 2022
@ethanfurman ethanfurman self-assigned this Dec 8, 2022
@netlify
Copy link

netlify bot commented Dec 8, 2022

Deploy Preview for python-cpython-preview canceled.

Name Link
🔨 Latest commit 0003880
🔍 Latest deploy log https://app.netlify.com/sites/python-cpython-preview/deploys/639181a6ad5e1d0009af22f7

@ethanfurman ethanfurman merged commit ded02ca into python:main Dec 8, 2022
@miss-islington
Copy link
Contributor

Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 8, 2022
…uto (pythonGH-100099)

When checking for auto() instances, only top-level usage is supported,
which means either alone or as part of a regular tuple. Other
containers, such as lists, dicts, or namedtuples, will not have auto()
transformed into a value.
(cherry picked from commit ded02ca)

Co-authored-by: Ethan Furman <[email protected]>
@bedevere-bot
Copy link

GH-100102 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Dec 8, 2022
miss-islington added a commit that referenced this pull request Dec 8, 2022
…H-100099)

When checking for auto() instances, only top-level usage is supported,
which means either alone or as part of a regular tuple. Other
containers, such as lists, dicts, or namedtuples, will not have auto()
transformed into a value.
(cherry picked from commit ded02ca)

Co-authored-by: Ethan Furman <[email protected]>
@ethanfurman ethanfurman deleted the enum-fix_namedtuple_auto branch February 1, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.11 only security fixes 3.12 bugs and security fixes stdlib Python modules in the Lib dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants