Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Help latest MSVC 1932 (v143, VS2022) to optimize PyObject_Free() #94841

Closed
neonene opened this issue Jul 14, 2022 · 1 comment
Closed

Help latest MSVC 1932 (v143, VS2022) to optimize PyObject_Free() #94841

neonene opened this issue Jul 14, 2022 · 1 comment
Labels
performance Performance or resource usage type-bug An unexpected behavior, bug, or error

Comments

@neonene
Copy link
Contributor

neonene commented Jul 14, 2022 •
edited by bedevere-bot
Loading

There is a report that python.org 3.11 Windows release has slowed down on micro benchmarks:

faster-cpython/ideas#420

One reason is that PyObject_Free() is not well optimized by the latest MSVC (ver.1932 in v143 tool set), which is likely to be used for the next 3.10 official as well.

This issue has been reported to the MSVC team. However, their tools would not be fixed urgently.

Linked PRs
@neonene neonene added the type-bug An unexpected behavior, bug, or error label Jul 14, 2022
@bedevere-bot bedevere-bot mentioned this issue Jul 14, 2022
Merged
@AlexWaygood AlexWaygood added the performance Performance or resource usage label Jul 14, 2022
gvanrossum pushed a commit that referenced this issue Jul 14, 2022
@neonene
gh-94841: Ensure arena_map_get() is inlined in PyObject_Free() (#94842)
9b3f779
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 14, 2022
@neonene @miss-islington
pythongh-94841: Ensure arena_map_get() is inlined in PyObject_Free() (p…
e1a54f4 
…ythonGH-94842)

(cherry picked from commit 9b3f779)

Co-authored-by: neonene <[email protected]>
@bedevere-bot bedevere-bot mentioned this issue Jul 14, 2022
Merged
miss-islington added a commit that referenced this issue Jul 14, 2022
@miss-islington @neonene
gh-94841: Ensure arena_map_get() is inlined in PyObject_Free() (GH-94842
498c649 
)

(cherry picked from commit 9b3f779)

Co-authored-by: neonene <[email protected]>
@gvanrossum
Copy link
Member

Thank you so much for this one-line fix giving 20% perf improvement (in some cases)!

nascheme pushed a commit to nascheme/cpython that referenced this issue Jul 14, 2022
@neonene @nascheme
[3.10] pythongh-94841: Ensure arena_map_get() is inlined in PyObject_…
7d0fb2b 
…Free() (pythonGH-94842)

Co-authored-by: Neil Schemenauer <[email protected]>
(cherry picked from commit d0850aa170580b494beda030a94fb04254e4acbc)

Co-authored-by: neonene <[email protected]>
@bedevere-bot bedevere-bot mentioned this issue Jul 14, 2022
Merged
nascheme added a commit that referenced this issue Jul 15, 2022
@nascheme @neonene
[3.10] gh-94841: Ensure arena_map_get() is inlined in PyObject_Free() (…
5d26f85 
…GH-94842)

Need to define ALWAYS_INLINE macro for 3.10.

Co-authored-by: neonene <[email protected]>
@bedevere-bot bedevere-bot mentioned this issue May 11, 2023
Merged
brandtbucher added a commit that referenced this issue May 12, 2023
@brandtbucher
GH-94841: Fix usage of Py_ALWAYS_INLINE (GH-104409)
a10b026
brandtbucher added a commit to brandtbucher/cpython that referenced this issue May 12, 2023
@brandtbucher
pythonGH-94841: Fix usage of Py_ALWAYS_INLINE
6e9b085
brandtbucher added a commit to brandtbucher/cpython that referenced this issue May 12, 2023
@brandtbucher
[3.11] pythonGH-94841: Fix usage of Py_ALWAYS_INLINE (pythonGH-104409).
912cd13 
(cherry picked from commit a10b026)

Co-authored-by: Brandt Bucher <[email protected]>
@bedevere-bot bedevere-bot mentioned this issue May 12, 2023
Merged
brandtbucher added a commit that referenced this issue May 12, 2023
@brandtbucher
[3.11] GH-94841: Fix usage of Py_ALWAYS_INLINE (GH-104439)
b90c922
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance Performance or resource usage type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gvanrossum @neonene @AlexWaygood