Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PCbuild/readme.txt mentions build_pgo.bat which was removed in python 3.6 #91795

Closed
peendebak opened this issue Apr 21, 2022 · 3 comments
Closed

PCbuild/readme.txt mentions build_pgo.bat which was removed in python 3.6 #91795

peendebak opened this issue Apr 21, 2022 · 3 comments
Labels
docs Documentation in the Doc dir OS-windows type-bug An unexpected behavior, bug, or error

Comments

@peendebak
Copy link
Contributor

peendebak commented Apr 21, 2022 •
edited by bedevere-bot
Loading

The file PCbuild/readme.txt still mentions the build_pgo.bat script, even though it was removed in python 3.6 (see https://github.com/python/cpython/blob/f4c03484da59049eb62a9bf7777b963e2267d187/Misc/NEWS.d/3.6.0a1.rst)

Linked PRs
@peendebak peendebak added the type-bug An unexpected behavior, bug, or error label Apr 21, 2022
@zware zware added docs Documentation in the Doc dir OS-windows labels Apr 21, 2022
@fatihkabakk
Copy link
Contributor

fatihkabakk commented Apr 22, 2022 •
edited
Loading

Also, this link in the See part is not found (404).
The correct one is this, I think.
Working on it for the main branch (3.11)

fatihkabakk added a commit to fatihkabakk/cpython that referenced this issue Apr 23, 2022
@fatihkabakk
pythongh-91795: Update build optimization part of PCbuild/readme.txt
0e4a7dd
@arhadthedev
Copy link
Member

@fatihkabakk Would you like to create a PR out of your fix-issue-91795 branch?

@bedevere-bot bedevere-bot mentioned this issue Jul 20, 2023
Merged
zooba pushed a commit that referenced this issue Aug 8, 2023
@fatihkabakk
gh-91795: Update build optimization part of PCbuild/readme.txt (GH-91849
906b73b 
)
@bedevere-bot bedevere-bot mentioned this issue Aug 8, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 8, 2023
@fatihkabakk @miss-islington
pythongh-91795: Update build optimization part of PCbuild/readme.txt (p…
5d5900d 
…ythonGH-91849)

(cherry picked from commit 906b73b)

Co-authored-by: Fatih <[email protected]>
@bedevere-bot bedevere-bot mentioned this issue Aug 8, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 8, 2023
@fatihkabakk @miss-islington
pythongh-91795: Update build optimization part of PCbuild/readme.txt (p…
05facf0 
…ythonGH-91849)

(cherry picked from commit 906b73b)

Co-authored-by: Fatih <[email protected]>
serhiy-storchaka pushed a commit that referenced this issue Aug 16, 2023
@miss-islington @fatihkabakk
[3.11] gh-91795: Update build optimization part of PCbuild/readme.txt (…
9e87e07 
…GH-91849) (GH-107777)

(cherry picked from commit 906b73b)

Co-authored-by: Fatih <[email protected]>
Yhg1s pushed a commit that referenced this issue Aug 16, 2023
@miss-islington @fatihkabakk
[3.12] gh-91795: Update build optimization part of PCbuild/readme.txt (…
8cb750d 
…GH-91849) (#107776)

gh-91795: Update build optimization part of PCbuild/readme.txt (GH-91849)
(cherry picked from commit 906b73b)

Co-authored-by: Fatih <[email protected]>
@hauntsaninja
Copy link
Contributor

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation in the Doc dir OS-windows type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@arhadthedev @zware @hauntsaninja @peendebak @fatihkabakk