Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyspecific directives are not translatable #84435

Closed
cocoatomo mannequin opened this issue Apr 11, 2020 · 3 comments
Closed

pyspecific directives are not translatable #84435

cocoatomo mannequin opened this issue Apr 11, 2020 · 3 comments
Labels
3.11 only security fixes 3.12 bugs and security fixes 3.13 bugs and security fixes docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error

Comments

@cocoatomo
Copy link
Mannequin

cocoatomo mannequin commented Apr 11, 2020

BPO 40254
Nosy @ezio-melotti, @merwok, @willingc, @cocoatomo, @JulienPalard
PRs
  • GH-84435: Make pyspecific directives translatable #19470
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2020-04-11.08:52:49.186>
    labels = ['3.8', 'type-bug', '3.7', '3.9', 'docs']
    title = 'pyspecific directives are not translatable'
    updated_at = <Date 2020-04-30.22:55:04.445>
    user = 'https://github.com/cocoatomo'

    bugs.python.org fields:

    activity = <Date 2020-04-30.22:55:04.445>
    actor = 'ned.deily'
    assignee = 'docs@python'
    closed = False
    closed_date = None
    closer = None
    components = ['Documentation']
    creation = <Date 2020-04-11.08:52:49.186>
    creator = 'cocoatomo'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 40254
    keywords = ['patch']
    message_count = 1.0
    messages = ['366196']
    nosy_count = 6.0
    nosy_names = ['ezio.melotti', 'eric.araujo', 'docs@python', 'willingc', 'cocoatomo', 'mdk']
    pr_nums = ['19470']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue40254'
    versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']

    Linked PRs

    @cocoatomo
    Copy link
    Mannequin Author

    cocoatomo mannequin commented Apr 11, 2020

    The new mechanism of Sphinx for internationalization was introduced at Sphinx 1.8, but directives implemented on pyspecific.py were not updated to follow that renewal.
    As a result, the text of these directives is left untranslated.
    (e.g. https://docs.python.org/ja/3.8/library/array.html)

    @cocoatomo cocoatomo mannequin added 3.7 (EOL) end of life 3.8 (EOL) end of life 3.9 only security fixes labels Apr 11, 2020
    @cocoatomo cocoatomo mannequin assigned docspython Apr 11, 2020
    @cocoatomo cocoatomo mannequin added docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error 3.7 (EOL) end of life 3.8 (EOL) end of life 3.9 only security fixes labels Apr 11, 2020
    @cocoatomo cocoatomo mannequin assigned docspython Apr 11, 2020
    @cocoatomo cocoatomo mannequin added docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error labels Apr 11, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @hugovk
    Copy link
    Member

    hugovk commented Aug 4, 2023

    See also #101986.

    @hugovk hugovk added 3.11 only security fixes 3.12 bugs and security fixes 3.13 bugs and security fixes and removed 3.9 only security fixes 3.8 (EOL) end of life 3.7 (EOL) end of life labels Aug 6, 2023
    hugovk pushed a commit that referenced this issue Aug 6, 2023
    miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 6, 2023
    (cherry picked from commit ecb05e0)
    
    Co-authored-by: cocoatomo <[email protected]>
    Co-authored-by: Jelle Zijlstra <[email protected]>
    Co-authored-by: Adam Turner <[email protected]>
    miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 6, 2023
    (cherry picked from commit ecb05e0)
    
    Co-authored-by: cocoatomo <[email protected]>
    Co-authored-by: Jelle Zijlstra <[email protected]>
    Co-authored-by: Adam Turner <[email protected]>
    Yhg1s pushed a commit that referenced this issue Aug 6, 2023
    …107681)
    
    GH-84435: Make pyspecific directives translatable (GH-19470)
    (cherry picked from commit ecb05e0)
    
    Co-authored-by: cocoatomo <[email protected]>
    Co-authored-by: Jelle Zijlstra <[email protected]>
    Co-authored-by: Adam Turner <[email protected]>
    hugovk pushed a commit that referenced this issue Aug 8, 2023
    …107682)
    
    GH-84435: Make pyspecific directives translatable (GH-19470)
    (cherry picked from commit ecb05e0)
    
    Co-authored-by: cocoatomo <[email protected]>
    Co-authored-by: Jelle Zijlstra <[email protected]>
    Co-authored-by: Adam Turner <[email protected]>
    @hugovk
    Copy link
    Member

    hugovk commented Aug 8, 2023

    Thanks, merged and backported.

    @hugovk hugovk closed this as completed Aug 8, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.11 only security fixes 3.12 bugs and security fixes 3.13 bugs and security fixes docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant