Attempt to further increase test coverage of calendar module #69714

RohitMediratta · 2015-11-01T09:57:44Z

BPO	25528
Nosy	@rhettinger, @vadmium, @serhiy-storchaka, @matrixise, @iritkatriel
Files	mywork.patch: Patch to increase coverage for 3 additional lines mywork_update.patch: Updated patch showing the correct diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2015-11-01.09:57:43.791>
labels = ['type-feature', 'tests']
title = 'Attempt to further increase test coverage of calendar module'
updated_at = <Date 2022-03-22.21:27:14.499>
user = 'https://bugs.python.org/RohitMediratta'

bugs.python.org fields:

activity = <Date 2022-03-22.21:27:14.499>
actor = 'iritkatriel'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Tests']
creation = <Date 2015-11-01.09:57:43.791>
creator = 'Rohit Mediratta'
dependencies = []
files = ['40916', '41109']
hgrepos = []
issue_num = 25528
keywords = ['patch']
message_count = 7.0
messages = ['253836', '254421', '255047', '255416', '255417', '255423', '415815']
nosy_count = 6.0
nosy_names = ['rhettinger', 'martin.panter', 'serhiy.storchaka', 'matrixise', 'Rohit Mediratta', 'iritkatriel']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue25528'
versions = ['Python 3.6']

Linked PRs

gh-69714: Make calendar module fully tested #93655

The text was updated successfully, but these errors were encountered:

RohitMediratta · 2015-11-01T09:57:43Z

Opened to submit a patch.

make patchcheck succeeded
full testsuite succeeded
Old coverage
Lib/calendar.py 375 54 86% 511, 519, 541, 608-699, 703
New coverage
Lib/calendar.py 375 51 86% 608-699, 703

vadmium · 2015-11-09T23:28:17Z

Rohit, it looks like your patch is reversed. The lines with a + sign already exist; are the - lines your proposed additions? Equivalently, revision f7db966c9fee already exists; is fb9d4ccbadf0 your new proposed revision?

Assuming the patch is reversed, I suggest keeping the locale=None case, perhaps as a separate test case or loop iteration. Otherwise you are throwing out one test case to add another.

RohitMediratta · 2015-11-21T08:59:10Z

Thanks for the comments. I did indeed have the patch reversed. I've resolved it here.

Martin: I had the locale=None case in the patch.

matrixise · 2015-11-26T13:14:17Z

no problem about the second patch of Rohit.

pass the test with default and I have tested the code in the REPL.

serhiy-storchaka · 2015-11-26T13:57:55Z

The problem with Rohit's patch is that it throws out existing test case.

matrixise · 2015-11-26T16:22:19Z

Sure,

But the patch is correct.

Now, you are right, we have to ask him a new patch where the function is really tested.

iritkatriel · 2022-03-22T21:27:14Z

The patch needs to be reviewed. If the tests are still relevant and increase coverage, it needs to be converted to a GitHub PR. Otherwise this issue can be closed.

See also bpo-13330.

AA-Turner · 2022-06-03T13:10:44Z

This hasn't been converted into a PR, if someone would like to we can re-open this issue in the future.

A

…}Calendar(locale='')`

….Locale{Text|HTML}Calendar` There are 3 paths to use `locale` argument in `calendar.Locale{Text|HTML}Calendar.__init__(..., locale=None)`: (1) `locale=None` -- denotes the "default locale"[1] (2) `locale=""` -- denotes the native environment (3) `locale=other_valid_locale` -- denotes a custom locale So far case (2) is covered and case (1) is in 78935da (same branch). This commit adds a remaining case (3). [1] In the current implementation, this translates into the following approach: GET current locale IF current locale == "C" THEN SET current locale TO "" GET current locale ENDIF

This condition cannot be true. `_locale.setlocale()` from the C module raises `locale.Error` instead of returning `None` for `different_locale.__enter__` (where `self.oldlocale` is set).

…monthname`

AA-Turner · 2022-06-09T18:52:55Z

Reopening as a new PR has appeared (#93655).

A

…verage)" This reverts commit a96786c.

… test coverage)"" This reverts commit 40e0da3. So it brings back commit a96786c.

No need to process the function. This also helps in supporting CLI testing.

These tests are now part of `test_illegal_arguments`. This reverts commit 238c527.

…ndar

terryjreedy · 2023-02-24T08:20:22Z

@bxsx Please leave the issue number off the commit message for all PR branch commits after the first. It spams the issue with unneeded info that is also on the PR itself.

There are 3 paths to use `locale` argument in `calendar.Locale{Text|HTML}Calendar.__init__(..., locale=None)`: (1) `locale=None` -- denotes the "default locale"[1] (2) `locale=""` -- denotes the native environment (3) `locale=other_valid_locale` -- denotes a custom locale So far case (2) is covered and case (1) is in 78935da (same branch). This commit adds a remaining case (3). [1] In the current implementation, this translates into the following approach: GET current locale IF current locale == "C" THEN SET current locale TO "" GET current locale ENDIF * Remove unreachable code (and increase test coverage) This condition cannot be true. `_locale.setlocale()` from the C module raises `locale.Error` instead of returning `None` for `different_locale.__enter__` (where `self.oldlocale` is set). * Expand the try clause to calls to `LocaleTextCalendar.formatmonthname()`. This method temporarily changes the current locale to the given locale, so `_locale.setlocale()` may raise `local.Error`. Co-authored-by: Rohit Mediratta <[email protected]> Co-authored-by: Jessica McKellar <[email protected]> Co-authored-by: Adam Turner <[email protected]> Co-authored-by: Irit Katriel <[email protected]>

RohitMediratta mannequin added tests Tests in the Lib/test dir type-feature A feature request or enhancement labels Nov 1, 2015

ezio-melotti transferred this issue from another repository Apr 10, 2022

AA-Turner closed this as not planned Won't fix, can't repro, duplicate, stale Jun 3, 2022

bxsx added a commit to bxsx/cpython that referenced this issue Jun 9, 2022

pythongh-69714: Restore the test thrown out by cb0523e

78935da

bxsx added a commit to bxsx/cpython that referenced this issue Jun 9, 2022

pythongh-69714: Increase test coverage for `calendar.Locale{Text|HTML…

0dd6321

…}Calendar(locale='')`

bxsx added a commit to bxsx/cpython that referenced this issue Jun 9, 2022

pythongh-69714: Increase CLI tests coverage

636b4e1

bxsx added a commit to bxsx/cpython that referenced this issue Jun 9, 2022

pythongh-69714: Add more test cases to calendar cmdline

238c527

bxsx added a commit to bxsx/cpython that referenced this issue Jun 9, 2022

pythongh-69714: Increase test coverage for calendar cmdline

b850c92

bxsx added a commit to bxsx/cpython that referenced this issue Jun 9, 2022

pythongh-69714: Increase test coverage for `LocaleTextCalendar.format…

f1febfc

…monthname`

bxsx added a commit to bxsx/cpython that referenced this issue Jun 9, 2022

Merge branch 'main' into pythongh-69714/calendar-test-coverage

e9e8825

bxsx mentioned this issue Jun 9, 2022

gh-69714: Make calendar module fully tested #93655

Merged

AA-Turner reopened this Jun 9, 2022

bxsx added a commit to bxsx/cpython that referenced this issue Jun 9, 2022

pythongh-69714: Reorder locale in the test case

d28e2e4

bxsx added a commit to bxsx/cpython that referenced this issue Jun 9, 2022

pythongh-69714: Extract test case

bbdc393

bxsx added a commit to bxsx/cpython that referenced this issue Jun 9, 2022

Revert "pythongh-69714: Remove unreachable code (and increase test co…

40e0da3

…verage)" This reverts commit a96786c.

bxsx added a commit to bxsx/cpython that referenced this issue Jun 9, 2022

Revert "Revert "pythongh-69714: Remove unreachable code (and increase…

64cb029

… test coverage)"" This reverts commit 40e0da3. So it brings back commit a96786c.

bxsx added a commit to bxsx/cpython that referenced this issue Jun 11, 2022

pythongh-69714: Move the validation to the beginning of the function

8b7bc06

No need to process the function. This also helps in supporting CLI testing.

bxsx added a commit to bxsx/cpython that referenced this issue Jun 11, 2022

pythongh-69714: Increase test coverage for illegal arguments

de21a51

bxsx added a commit to bxsx/cpython that referenced this issue Jun 11, 2022

Revert "pythongh-69714: Add more test cases to calendar cmdline"

ab5a508

These tests are now part of `test_illegal_arguments`. This reverts commit 238c527.

bxsx added a commit to bxsx/cpython that referenced this issue Jun 11, 2022

pythongh-69714: Split tests for LocaleTextCalendar and LocaleHTMLCale…

e73fc9e

…ndar

bxsx added a commit to bxsx/cpython that referenced this issue Jul 21, 2023

Merge branch 'main' into pythongh-69714/calendar-test-coverage

87feac0

bxsx added a commit to bxsx/cpython that referenced this issue Jul 21, 2023

Merge branch 'main' into pythongh-69714/calendar-test-coverage

81d09b2

ambv closed this as completed in #93655 Jul 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Attempt to further increase test coverage of calendar module #69714

Attempt to further increase test coverage of calendar module #69714

RohitMediratta mannequin commented Nov 1, 2015 •

edited by bedevere-bot

Loading

RohitMediratta mannequin commented Nov 1, 2015

vadmium commented Nov 9, 2015

RohitMediratta mannequin commented Nov 21, 2015

matrixise commented Nov 26, 2015

serhiy-storchaka commented Nov 26, 2015

matrixise commented Nov 26, 2015

iritkatriel commented Mar 22, 2022

AA-Turner commented Jun 3, 2022

AA-Turner commented Jun 9, 2022

terryjreedy commented Feb 24, 2023

Attempt to further increase test coverage of calendar module #69714

Attempt to further increase test coverage of calendar module #69714

Comments

RohitMediratta mannequin commented Nov 1, 2015 • edited by bedevere-bot Loading

Linked PRs

RohitMediratta mannequin commented Nov 1, 2015

vadmium commented Nov 9, 2015

RohitMediratta mannequin commented Nov 21, 2015

matrixise commented Nov 26, 2015

serhiy-storchaka commented Nov 26, 2015

matrixise commented Nov 26, 2015

iritkatriel commented Mar 22, 2022

AA-Turner commented Jun 3, 2022

AA-Turner commented Jun 9, 2022

terryjreedy commented Feb 24, 2023

RohitMediratta mannequin commented Nov 1, 2015 •

edited by bedevere-bot

Loading