Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

this_instr should be const in generated code. this_instr is generated, and should be const. #125039

Open
markshannon opened this issue Oct 7, 2024 · 0 comments
Open

this_instr should be const in generated code. this_instr is generated, and should be const. #125039

markshannon opened this issue Oct 7, 2024 · 0 comments
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Comments

@markshannon
Copy link
Member

markshannon commented Oct 7, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

We currently generate

_Py_CODEUNIT *this_instr =...

we should generate

_Py_CODEUNIT* const this_instr =...

to prevent it being accidentally changed.

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markshannon @picnixz