Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pyrepl on windows is blocking where it shouldn't #124628

Open
DinoV opened this issue Sep 26, 2024 · 0 comments
Open

Pyrepl on windows is blocking where it shouldn't #124628

DinoV opened this issue Sep 26, 2024 · 0 comments
Labels
OS-windows topic-repl Related to the interactive shell type-bug An unexpected behavior, bug, or error

Comments

@DinoV
Copy link
Contributor

DinoV commented Sep 26, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

ReadConsoleInput is documented as always returning at least one input. This breaks things in a couple of spots:

  • searching inputs and hitting ctrl-c. This blocks reading, a 2nd ctrl-c is required, and then the interpreter crashes.
  • Background exceptions with a partial input. This should display the exception and do a keyboard interrupt, but it only happens on the next keypress.

CPython versions tested on:

CPython main branch

Operating systems tested on:

Windows

Linked PRs
@DinoV DinoV added the type-bug An unexpected behavior, bug, or error label Sep 26, 2024
@bedevere-app bedevere-app bot mentioned this issue Sep 26, 2024
Merged
@Eclips4 Eclips4 added OS-windows topic-repl Related to the interactive shell labels Sep 26, 2024
ambv pushed a commit that referenced this issue Sep 26, 2024
@DinoV
gh-124628: Pyrepl inputs on Windows shouldn't always be blocking reads (
83e5dc0 
#124629)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 26, 2024
@DinoV @miss-islington
pythongh-124628: Pyrepl inputs on Windows shouldn't always be blockin…
9716690 
…g reads (pythonGH-124629)

(cherry picked from commit 83e5dc0)

Co-authored-by: Dino Viehland <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Sep 26, 2024
Merged
Yhg1s pushed a commit that referenced this issue Sep 27, 2024
@miss-islington @DinoV
[3.13] gh-124628: Pyrepl inputs on Windows shouldn't always be blocki…
862ec8b 
…ng reads (GH-124629) (#124638)

gh-124628: Pyrepl inputs on Windows shouldn't always be blocking reads (GH-124629)
(cherry picked from commit 83e5dc0)

Co-authored-by: Dino Viehland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OS-windows topic-repl Related to the interactive shell type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DinoV @Eclips4