Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PyList_GetItemRef, a variant of PyList_GetItem that returns a strong reference #114329

Closed
Tracked by #108219
colesbury opened this issue Jan 19, 2024 · 3 comments
Closed
Tracked by #108219

Add PyList_GetItemRef, a variant of PyList_GetItem that returns a strong reference #114329

colesbury opened this issue Jan 19, 2024 · 3 comments
Labels
topic-C-API topic-free-threading type-feature A feature request or enhancement

Comments

@colesbury
Copy link
Contributor

colesbury commented Jan 19, 2024 •
edited by bedevere-app bot
Loading

Feature or enhancement

The free-threaded builds need a variant of PyList_GetItem that returns a strong reference instead of a borrowed reference for thread-safety reasons. PEP 703 proposed PyList_FetchItem, but since then PyDict_GetItemRef and functions with similar signatures have been added.

This proposes PyList_GetItemRef with the following signature:

PyObject *PyList_GetItemRef(PyObject *list, Py_ssize_t index)

Return a strong reference to the object at position index in the list pointed to by list. If index is out of bounds (<0 or >=len(list)), return NULL and set an IndexError. If list is not a list instance, return NULL and set a TypeError.

Linked PRs
@colesbury colesbury added type-feature A feature request or enhancement topic-C-API 3.13 bugs and security fixes topic-free-threading labels Jan 19, 2024
@colesbury colesbury mentioned this issue Jan 19, 2024
Closed
@colesbury
Copy link
Contributor Author

C-API working group issue: capi-workgroup/decisions#9

@colesbury colesbury mentioned this issue Jan 19, 2024
Open
@Eclips4
Copy link
Member

Eclips4 commented Jan 19, 2024

Just FYI, feature requests do not need version label :)

@Eclips4 Eclips4 removed the 3.13 bugs and security fixes label Jan 19, 2024
colesbury added a commit to colesbury/cpython that referenced this issue Jan 23, 2024
@colesbury
pythongh-114329: Add PyList_GetItemRef function
8f96d08 
The new `PyList_GetItemRef` is similar to `PyList_GetItem`, but returns
a strong reference instead of a borrowed reference. Additionally, if the
passed "list" object is not a list, the function sets a `TypeError`
instead of calling `PyErr_BadInternalCall()`.
@bedevere-app bedevere-app bot mentioned this issue Jan 23, 2024
Merged
colesbury added a commit to colesbury/cpython that referenced this issue Jan 30, 2024
@colesbury
Merge branch 'main' into pythongh-114329-list
c045495
encukou pushed a commit that referenced this issue Feb 2, 2024
@colesbury
gh-114329: Add PyList_GetItemRef function (GH-114504)
d0f1307 
The new `PyList_GetItemRef` is similar to `PyList_GetItem`, but returns
a strong reference instead of a borrowed reference. Additionally, if the
passed "list" object is not a list, the function sets a `TypeError`
instead of calling `PyErr_BadInternalCall()`.
@encukou
Copy link
Member

encukou commented Feb 2, 2024

Thank you!

@encukou encukou closed this as completed Feb 2, 2024
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@colesbury @aisk
pythongh-114329: Add PyList_GetItemRef function (pythonGH-114504)
445e147 
The new `PyList_GetItemRef` is similar to `PyList_GetItem`, but returns
a strong reference instead of a borrowed reference. Additionally, if the
passed "list" object is not a list, the function sets a `TypeError`
instead of calling `PyErr_BadInternalCall()`.
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this issue Feb 14, 2024
@colesbury @fsc-eriker
pythongh-114329: Add PyList_GetItemRef function (pythonGH-114504)
d3c77d1 
The new `PyList_GetItemRef` is similar to `PyList_GetItem`, but returns
a strong reference instead of a borrowed reference. Additionally, if the
passed "list" object is not a list, the function sets a `TypeError`
instead of calling `PyErr_BadInternalCall()`.
@vstinner vstinner mentioned this issue Apr 3, 2024
Closed
vstinner added a commit to vstinner/cpython that referenced this issue Apr 3, 2024
@vstinner
pythongh-114329: Fix PyList_GetItemRef() limited C API definition
450b389
@bedevere-app bedevere-app bot mentioned this issue Apr 3, 2024
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Apr 3, 2024
@vstinner
pythongh-114329: Fix PyList_GetItemRef() limited C API definition
934a220
vstinner added a commit that referenced this issue Apr 3, 2024
@vstinner
gh-114329: Fix PyList_GetItemRef() limited C API definition (#117520)
2057c92
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@vstinner @diegorusso
pythongh-114329: Fix PyList_GetItemRef() limited C API definition (py…
47e396c 
…thon#117520)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic-C-API topic-free-threading type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@encukou @colesbury @Eclips4