Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C API: Cleanup header files #108765

Closed
vstinner opened this issue Sep 1, 2023 · 0 comments
Closed

C API: Cleanup header files #108765

vstinner opened this issue Sep 1, 2023 · 0 comments
Labels
type-feature A feature request or enhancement

Comments

@vstinner
Copy link
Member

vstinner commented Sep 1, 2023 •
edited by bedevere-app bot
Loading

Feature or enhancement

Has this already been discussed elsewhere?

No response given

Links to previous discussion of this feature:

No response

Proposal:

Meta issue for a few changes related to C API header files.

Linked PRs
@vstinner vstinner added the type-feature A feature request or enhancement label Sep 1, 2023
@bedevere-bot bedevere-bot mentioned this issue Sep 1, 2023
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Sep 1, 2023
@vstinner
pythongh-108765: Reformat Include/osdefs.h
e952efe
@bedevere-bot bedevere-bot mentioned this issue Sep 1, 2023
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Sep 1, 2023
@vstinner
pythongh-108765: Move standard includes to Python.h
26d6447 
* Move <ctype.h>, <limits.h> and <stdarg.h> includes to Python.h.
* Move "pystats.h" include from object.h to Python.h.
* Remove redundant "pymem.h" include in objimpl.h and "pyport.h"
  include in pymem.h; Python.h already includes them earlier.
* Remove redundant <wchar.h> include in unicodeobject.h; Python.h
  already includes it.
* Move _SGI_MP_SOURCE define from Python.h to pyport.h.
* pycore_condvar.h includes explicitly <unistd.h> for the
  _POSIX_THREADS macro.
vstinner added a commit to vstinner/cpython that referenced this issue Sep 1, 2023
@vstinner
pythongh-108765: Move standard includes to Python.h
cb128f2 
* Move <ctype.h>, <limits.h> and <stdarg.h> standard includes to
  Python.h.
* Move "pystats.h" include from object.h to Python.h.
* Remove redundant "pymem.h" include in objimpl.h and "pyport.h"
  include in pymem.h; Python.h already includes them earlier.
* Remove redundant <wchar.h> include in unicodeobject.h; Python.h
  already includes it.
* Move _SGI_MP_SOURCE define from Python.h to pyport.h.
* pycore_condvar.h includes explicitly <unistd.h> for the
  _POSIX_THREADS macro.
vstinner added a commit to vstinner/cpython that referenced this issue Sep 1, 2023
@vstinner
pythongh-108765: Move standard includes to Python.h
835caae 
* Move <ctype.h>, <limits.h> and <stdarg.h> standard includes to
  Python.h.
* Move "pystats.h" include from object.h to Python.h.
* Remove redundant "pymem.h" include in objimpl.h and "pyport.h"
  include in pymem.h; Python.h already includes them earlier.
* Remove redundant <wchar.h> include in unicodeobject.h; Python.h
  already includes it.
* Move _SGI_MP_SOURCE define from Python.h to pyport.h.
* pycore_condvar.h includes explicitly <unistd.h> for the
  _POSIX_THREADS macro.
vstinner added a commit that referenced this issue Sep 1, 2023
@vstinner
gh-108765: Reformat Include/osdefs.h (#108766)
5948f56
vstinner added a commit to vstinner/cpython that referenced this issue Sep 1, 2023
@vstinner
pythongh-108765: Move standard includes to Python.h
a710a2b 
* Move <ctype.h>, <limits.h> and <stdarg.h> standard includes to
  Python.h.
* Move "pystats.h" include from object.h to Python.h.
* Remove redundant "pymem.h" include in objimpl.h and "pyport.h"
  include in pymem.h; Python.h already includes them earlier.
* Remove redundant <wchar.h> include in unicodeobject.h; Python.h
  already includes it.
* Move _SGI_MP_SOURCE define from Python.h to pyport.h.
* pycore_condvar.h includes explicitly <unistd.h> for the
  _POSIX_THREADS macro.
vstinner added a commit that referenced this issue Sep 1, 2023
@vstinner
gh-108765: Reformat Include/pymacconfig.h (#108764)
03c5a68 
Replace "MacOSX" with "macOS".
@bedevere-bot bedevere-bot mentioned this issue Sep 1, 2023
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Sep 1, 2023
@vstinner
pythongh-108765: Python.h no longer includes <sys/time.h>
26cf3e5 
Python.h no longer includes these standard header files: <time.h>,
<sys/select.h> and <sys/time.h>. They should now be included
explicitly if needed.
@bedevere-bot bedevere-bot mentioned this issue Sep 1, 2023
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Sep 1, 2023
@vstinner
pythongh-108765: Remove legacy prototypes from pyport.h
c6d274d 
Remove prototypes for old Solaris and old QNX versions from pyport.h.
@bedevere-bot bedevere-bot mentioned this issue Sep 1, 2023
Closed
vstinner added a commit to vstinner/cpython that referenced this issue Sep 1, 2023
@vstinner
pythongh-108765: Python.h no longer includes <ieeefp.h>
364a59d
@bedevere-bot bedevere-bot mentioned this issue Sep 1, 2023
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Sep 1, 2023
@vstinner
pythongh-108765: Remove old prototypes from pyport.h
7385795 
Move prototypes of gethostname(), _getpty() and struct termios from
pyport.h to the C code using them: posixmodule.c, socketmodule.c and
termios.c.

Replace "#ifdef SOLARIS" with "#ifdef __sun".
@bedevere-bot bedevere-bot mentioned this issue Sep 1, 2023
Merged
vstinner added a commit that referenced this issue Sep 1, 2023
@vstinner
gh-108765: Move standard includes to Python.h (#108769)
45b9e6a 
* Move <ctype.h>, <limits.h> and <stdarg.h> standard includes to
  Python.h.
* Move "pystats.h" include from object.h to Python.h.
* Remove redundant "pymem.h" include in objimpl.h and "pyport.h"
  include in pymem.h; Python.h already includes them earlier.
* Remove redundant <wchar.h> include in unicodeobject.h; Python.h
  already includes it.
* Move _SGI_MP_SOURCE define from Python.h to pyport.h.
* pycore_condvar.h includes explicitly <unistd.h> for the
  _POSIX_THREADS macro.
vstinner added a commit to vstinner/cpython that referenced this issue Sep 1, 2023
@vstinner
pythongh-108765: Remove <unistd.h> include from Python.h
5264875
vstinner added a commit to vstinner/cpython that referenced this issue Sep 1, 2023
@vstinner
pythongh-108765: Python.h no longer includes <unistd.h>
dddca41
@bedevere-bot bedevere-bot mentioned this issue Sep 1, 2023
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Sep 1, 2023
@vstinner
pythongh-108765: Python.h no longer includes <sys/time.h>
12a842c
vstinner added a commit to vstinner/cpython that referenced this issue Sep 1, 2023
@vstinner
pythongh-108765: Python.h no longer includes <ieeefp.h>
7f04dda
vstinner added a commit to vstinner/cpython that referenced this issue Sep 1, 2023
@vstinner
pythongh-108765: Remove old prototypes from pyport.h
1b43dc1
vstinner added a commit to vstinner/cpython that referenced this issue Sep 1, 2023
@vstinner
pythongh-108765: Python.h no longer includes <unistd.h>
6aede60
@bedevere-bot bedevere-bot mentioned this issue Sep 1, 2023
Closed
vstinner added a commit to vstinner/cpython that referenced this issue Sep 2, 2023
@vstinner
pythongh-108765: Python.h no longer includes <ieeefp.h>
57330ce 
Remove also the HAVE_IEEEFP_H macro: remove ieeefp.h from the
AC_CHECK_HEADERS() check of configure.ac.
vstinner added a commit that referenced this issue Sep 2, 2023
@vstinner
gh-108765: Remove old prototypes from pyport.h (#108782)
1f3e797 
Move prototypes of gethostname(), _getpty() and struct termios from
pyport.h to the C code using them: posixmodule.c, socketmodule.c and
termios.c.

Replace "#ifdef SOLARIS" with "#ifdef __sun".
@bedevere-bot bedevere-bot mentioned this issue Sep 3, 2023
Merged
vstinner added a commit that referenced this issue Sep 3, 2023
@vstinner
gh-108765: Move stat() fiddling from pyport.h to fileutils.h (#108854)
c2ec174
vstinner added a commit to vstinner/cpython that referenced this issue Sep 3, 2023
@vstinner
pythongh-108765: Move export code from pyport.h to exports.h
e2c99fa
vstinner added a commit to vstinner/cpython that referenced this issue Sep 3, 2023
@vstinner
pythongh-108765: Move export code from pyport.h to exports.h
31ab8cc 
There is no API change, since pyport.h includes exports.h.
@bedevere-bot bedevere-bot mentioned this issue Sep 3, 2023
Merged
vstinner added a commit that referenced this issue Sep 3, 2023
@vstinner
gh-108765: Move export code from pyport.h to exports.h (#108855)
44fc378 
There is no API change, since pyport.h includes exports.h.
hugovk pushed a commit to hugovk/cpython that referenced this issue Sep 4, 2023
@vstinner @hugovk
pythongh-108765: Move export code from pyport.h to exports.h (python#…
f31e6ae 
…108855)

There is no API change, since pyport.h includes exports.h.
vstinner pushed a commit to vstinner/cpython that referenced this issue Sep 6, 2023
@nabin2004 @vstinner
pythongh-108765: Cleanup #include in Python/*.c files
3370546
vstinner pushed a commit to vstinner/cpython that referenced this issue Sep 6, 2023
@nabin2004 @vstinner
pythongh-108765: Cleanup #include in Python/*.c files
c9acc9b
@bedevere-bot bedevere-bot mentioned this issue Sep 6, 2023
Merged
vstinner added a commit that referenced this issue Sep 6, 2023
@vstinner
gh-108765: Cleanup #include in Python/*.c files (#108977)
b298b39 
Mention one symbol imported by each #include.
@serhiy-storchaka serhiy-storchaka mentioned this issue Oct 9, 2023
Closed
@ambv ambv mentioned this issue Oct 25, 2023
Closed
vstinner added a commit to vstinner/cpython that referenced this issue Oct 27, 2023
@vstinner
pythongh-108765: Include explicitly <unistd.h> in signalmodule.c
4c83aa2 
unistd.h is needed by alarm() and pause().
@bedevere-app bedevere-app bot mentioned this issue Oct 27, 2023
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Oct 27, 2023
@vstinner
pythongh-108765: Include explicitly <unistd.h> in signalmodule.c
98a8483 
unistd.h is needed by alarm() and pause().
vstinner added a commit that referenced this issue Oct 27, 2023
@vstinner
gh-108765: Include explicitly <unistd.h> in signalmodule.c (#111402)
77bb0d5 
unistd.h is needed by alarm() and pause() functions.
iritkatriel pushed a commit to iritkatriel/cpython that referenced this issue Oct 29, 2023
@vstinner @iritkatriel
pythongh-108765: Include explicitly <unistd.h> in signalmodule.c (pyt…
64ca0a9 
…hon#111402)

unistd.h is needed by alarm() and pause() functions.
vstinner added a commit to vstinner/cpython that referenced this issue Oct 31, 2023
@vstinner
pythongh-108765: No longer include <stddef.h> in Python.h
26b472e 
In practice, only Windows is impacted, since the HAVE_STDDEF_H macro
was only defined on this platform.
vstinner added a commit to vstinner/cpython that referenced this issue Oct 31, 2023
@vstinner
pythongh-108765: Python.h no longer includes <stddef.h>
dd2ef4c 
In practice, only Windows is impacted, since the HAVE_STDDEF_H macro
was only defined on this platform.
vstinner added a commit to vstinner/cpython that referenced this issue Oct 31, 2023
@vstinner
pythongh-108765: Python.h no longer includes <stddef.h> on Windows
155c6ec 
In practice, only Windows is impacted, because the HAVE_STDDEF_H
macro was only defined on Windows.
@bedevere-app bedevere-app bot mentioned this issue Oct 31, 2023
Merged
vstinner added a commit that referenced this issue Oct 31, 2023
@vstinner
gh-108765: Python.h no longer includes <stddef.h> on Windows (#111563)
faa5f60 
In practice, only Windows is impacted, because the HAVE_STDDEF_H
macro was only defined on Windows.
FullteaR pushed a commit to FullteaR/cpython that referenced this issue Nov 3, 2023
@vstinner @FullteaR
pythongh-108765: Python.h no longer includes <stddef.h> on Windows (p…
7c98195 
…ython#111563)

In practice, only Windows is impacted, because the HAVE_STDDEF_H
macro was only defined on Windows.
@vstinner vstinner mentioned this issue Nov 14, 2023
Merged
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@vstinner @aisk
pythongh-108765: Include explicitly <unistd.h> in signalmodule.c (pyt…
221cbcd 
…hon#111402)

unistd.h is needed by alarm() and pause() functions.
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@vstinner @aisk
pythongh-108765: Python.h no longer includes <stddef.h> on Windows (p…
731fc42 
…ython#111563)

In practice, only Windows is impacted, because the HAVE_STDDEF_H
macro was only defined on Windows.
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@vstinner @Glyphack
pythongh-108765: Include explicitly <unistd.h> in signalmodule.c (pyt…
7784732 
…hon#111402)

unistd.h is needed by alarm() and pause() functions.
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@vstinner @Glyphack
pythongh-108765: Python.h no longer includes <stddef.h> on Windows (p…
53e8c9c 
…ython#111563)

In practice, only Windows is impacted, because the HAVE_STDDEF_H
macro was only defined on Windows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vstinner