Skip to content

Commit

Permalink
gh-120039: Reduce expected timeout in test_siginterrupt_off (#120047)
Browse files Browse the repository at this point in the history
The process is expected to time out. In the refleak builds,
`support.SHORT_TIMEOUT` is often five minutes and we run the tests six
times, so test_signal was taking >30 minutes.
  • Loading branch information
colesbury authored Jun 4, 2024
1 parent bf8e5e5 commit d419d46
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Lib/test/test_signal.py
Original file line number Diff line number Diff line change
Expand Up @@ -698,7 +698,7 @@ def handler(signum, frame):
@unittest.skipUnless(hasattr(os, "pipe"), "requires os.pipe()")
class SiginterruptTest(unittest.TestCase):

def readpipe_interrupted(self, interrupt):
def readpipe_interrupted(self, interrupt, timeout=support.SHORT_TIMEOUT):
"""Perform a read during which a signal will arrive. Return True if the
read is interrupted by the signal and raises an exception. Return False
if it returns normally.
Expand Down Expand Up @@ -746,7 +746,7 @@ def handler(signum, frame):
# wait until the child process is loaded and has started
first_line = process.stdout.readline()

stdout, stderr = process.communicate(timeout=support.SHORT_TIMEOUT)
stdout, stderr = process.communicate(timeout=timeout)
except subprocess.TimeoutExpired:
process.kill()
return False
Expand Down Expand Up @@ -777,7 +777,7 @@ def test_siginterrupt_off(self):
# If a signal handler is installed and siginterrupt is called with
# a false value for the second argument, when that signal arrives, it
# does not interrupt a syscall that's in progress.
interrupted = self.readpipe_interrupted(False)
interrupted = self.readpipe_interrupted(False, timeout=2)
self.assertFalse(interrupted)


Expand Down

0 comments on commit d419d46

Please sign in to comment.