Skip to content

Commit

Permalink
gh-119896: Fix CTRL-Z behavior in the new REPL on Windows (GH-122217)
Browse files Browse the repository at this point in the history
  • Loading branch information
DinoV authored Jul 30, 2024
1 parent d27a53f commit d1a1bca
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 4 deletions.
9 changes: 7 additions & 2 deletions Lib/_pyrepl/reader.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@

from __future__ import annotations

import sys

from contextlib import contextmanager
from dataclasses import dataclass, field, fields
import unicodedata
Expand Down Expand Up @@ -52,7 +54,10 @@ def disp_str(buffer: str) -> tuple[str, list[int]]:
b: list[int] = []
s: list[str] = []
for c in buffer:
if ord(c) < 128:
if c == '\x1a':
s.append(c)
b.append(2)
elif ord(c) < 128:
s.append(c)
b.append(1)
elif unicodedata.category(c).startswith("C"):
Expand Down Expand Up @@ -110,7 +115,7 @@ def make_default_commands() -> dict[CommandName, type[Command]]:
(r"\C-w", "unix-word-rubout"),
(r"\C-x\C-u", "upcase-region"),
(r"\C-y", "yank"),
(r"\C-z", "suspend"),
*(() if sys.platform == "win32" else ((r"\C-z", "suspend"), )),
(r"\M-b", "backward-word"),
(r"\M-c", "capitalize-word"),
(r"\M-d", "kill-word"),
Expand Down
1 change: 1 addition & 0 deletions Lib/_pyrepl/simple_interact.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ def _clear_screen():
"copyright": _sitebuiltins._Printer('copyright', sys.copyright),
"help": "help",
"clear": _clear_screen,
"\x1a": _sitebuiltins.Quitter('\x1a', ''),
}


Expand Down
3 changes: 2 additions & 1 deletion Lib/_pyrepl/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,5 @@ def wlen(s: str) -> int:
length = sum(str_width(i) for i in s)
# remove lengths of any escape sequences
sequence = ANSI_ESCAPE_SEQUENCE.findall(s)
return length - sum(len(i) for i in sequence)
ctrl_z_cnt = s.count('\x1a')
return length - sum(len(i) for i in sequence) + ctrl_z_cnt
5 changes: 4 additions & 1 deletion Lib/_pyrepl/windows_console.py
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ def __write_changed_line(
else:
self.__posxy = wlen(newline), y

if "\x1b" in newline or y != self.__posxy[1]:
if "\x1b" in newline or y != self.__posxy[1] or '\x1a' in newline:
# ANSI escape characters are present, so we can't assume
# anything about the position of the cursor. Moving the cursor
# to the left margin should work to get to a known position.
Expand Down Expand Up @@ -291,6 +291,9 @@ def _disable_blinking(self):
self.__write("\x1b[?12l")

def __write(self, text: str) -> None:
if "\x1a" in text:
text = ''.join(["^Z" if x == '\x1a' else x for x in text])

if self.out is not None:
self.out.write(text.encode(self.encoding, "replace"))
self.out.flush()
Expand Down

0 comments on commit d1a1bca

Please sign in to comment.