Skip to content

Commit

Permalink
bpo-31174: Improve the code of test_tools.test_unparse. (GH-4146) (#4148
Browse files Browse the repository at this point in the history
)

(cherry picked from commit 7351f9e)
  • Loading branch information
miss-islington authored and serhiy-storchaka committed Oct 27, 2017
1 parent 37d1d96 commit bb78898
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions Lib/test/test_tools/test_unparse.py
Original file line number Diff line number Diff line change
Expand Up @@ -268,12 +268,13 @@ class DirectoryTestCase(ASTTestCase):
# test directories, relative to the root of the distribution
test_directories = 'Lib', os.path.join('Lib', 'test')

def get_names(self):
if DirectoryTestCase.NAMES is not None:
return DirectoryTestCase.NAMES
@classmethod
def get_names(cls):
if cls.NAMES is not None:
return cls.NAMES

names = []
for d in self.test_directories:
for d in cls.test_directories:
test_dir = os.path.join(basepath, d)
for n in os.listdir(test_dir):
if n.endswith('.py') and not n.startswith('bad'):
Expand All @@ -282,10 +283,9 @@ def get_names(self):
# Test limited subset of files unless the 'cpu' resource is specified.
if not test.support.is_resource_enabled("cpu"):
names = random.sample(names, 10)
# bpo-31174: Store the names sample to always test the same files.
# It prevents false alarms when hunting reference leaks.
DirectoryTestCase.NAMES = names

# bpo-31174: Store the names sample to always test the same files.
# It prevents false alarms when hunting reference leaks.
cls.NAMES = names
return names

def test_files(self):
Expand Down

0 comments on commit bb78898

Please sign in to comment.