Skip to content

Commit

Permalink
bpo-27961: Replace PY_LONG_LONG with long long. (GH-15386)
Browse files Browse the repository at this point in the history
  • Loading branch information
sir-sigurd authored and serhiy-storchaka committed Oct 21, 2019
1 parent 919f0bc commit a9ed91e
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions Lib/test/clinic.test
Original file line number Diff line number Diff line change
Expand Up @@ -1269,7 +1269,7 @@ test_long_long_converter(PyObject *module, PyObject *const *args, Py_ssize_t nar
goto exit;
}
a = PyLong_AsLongLong(args[0]);
if (a == (PY_LONG_LONG)-1 && PyErr_Occurred()) {
if (a == -1 && PyErr_Occurred()) {
goto exit;
}
skip_optional:
Expand All @@ -1281,7 +1281,7 @@ exit:

static PyObject *
test_long_long_converter_impl(PyObject *module, long long a)
/*[clinic end generated code: output=3e8083f3aee4f18a input=d5fc81577ff4dd02]*/
/*[clinic end generated code: output=7143b585d7e433e8 input=d5fc81577ff4dd02]*/


/*[clinic input]
Expand Down
4 changes: 2 additions & 2 deletions Modules/_testcapimodule.c
Original file line number Diff line number Diff line change
Expand Up @@ -4763,8 +4763,8 @@ dict_get_version(PyObject *self, PyObject *args)

version = dict->ma_version_tag;

Py_BUILD_ASSERT(sizeof(unsigned PY_LONG_LONG) >= sizeof(version));
return PyLong_FromUnsignedLongLong((unsigned PY_LONG_LONG)version);
Py_BUILD_ASSERT(sizeof(unsigned long long) >= sizeof(version));
return PyLong_FromUnsignedLongLong((unsigned long long)version);
}


Expand Down
2 changes: 1 addition & 1 deletion PC/pyconfig.h
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ Py_NO_ENABLE_SHARED to find out. Also support MS_NO_COREDLL for b/w compat */
# define SIZEOF_HKEY 8
# define SIZEOF_SIZE_T 8
/* configure.ac defines HAVE_LARGEFILE_SUPPORT iff
sizeof(off_t) > sizeof(long), and sizeof(PY_LONG_LONG) >= sizeof(off_t).
sizeof(off_t) > sizeof(long), and sizeof(long long) >= sizeof(off_t).
On Win64 the second condition is not true, but if fpos_t replaces off_t
then this is true. The uses of HAVE_LARGEFILE_SUPPORT imply that Win64
should define this. */
Expand Down
2 changes: 1 addition & 1 deletion Tools/clinic/clinic.py
Original file line number Diff line number Diff line change
Expand Up @@ -3016,7 +3016,7 @@ def parse_arg(self, argname, displayname):
goto exit;
}}}}
{paramname} = PyLong_AsLongLong({argname});
if ({paramname} == (PY_LONG_LONG)-1 && PyErr_Occurred()) {{{{
if ({paramname} == -1 && PyErr_Occurred()) {{{{
goto exit;
}}}}
""".format(argname=argname, paramname=self.name)
Expand Down

0 comments on commit a9ed91e

Please sign in to comment.