Skip to content

Commit

Permalink
Fix incorrect success statement in status change comment (#501)
Browse files Browse the repository at this point in the history
Co-authored-by: Mariatta Wijaya <[email protected]>
  • Loading branch information
jacobtylerwalls and Mariatta authored Jan 7, 2022
1 parent 6375e9d commit 9fd4926
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion miss_islington/status_change.py
Original file line number Diff line number Diff line change
Expand Up @@ -133,13 +133,15 @@ async def check_ci_status_and_approval(
)
if success:
emoji = "✅"
description = "success"
else:
emoji = "❌"
description = "failure"
print("leaving a comment")
await util.leave_comment(
gh,
pr_number=pr_number,
message=f"{participants}: Status check is done, and it's a {result['state']} {emoji} .",
message=f"{participants}: Status check is done, and it's a {description} {emoji} .",
)
if success:
if util.pr_is_awaiting_merge(pr_for_commit["labels"]):
Expand Down

0 comments on commit 9fd4926

Please sign in to comment.