Skip to content

Commit

Permalink
Add a comment about how to fix bogus test_host_resolution_bad_address…
Browse files Browse the repository at this point in the history
… failures (#29085)
  • Loading branch information
warsaw authored Oct 20, 2021
1 parent 8863a0f commit 6ef4507
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions Lib/test/test_socket.py
Original file line number Diff line number Diff line change
Expand Up @@ -1017,8 +1017,10 @@ def test_host_resolution(self):

def test_host_resolution_bad_address(self):
# These are all malformed IP addresses and expected not to resolve to
# any result. But some ISPs, e.g. AWS, may successfully resolve these
# IPs.
# any result. But some ISPs, e.g. AWS and AT&T, may successfully
# resolve these IPs. In particular, AT&T's DNS Error Assist service
# will break this test. See https://bugs.python.org/issue42092 for a
# workaround.
explanation = (
"resolving an invalid IP address did not raise OSError; "
"can be caused by a broken DNS server"
Expand Down

0 comments on commit 6ef4507

Please sign in to comment.