Skip to content

Commit

Permalink
gh-74468: [tarfile] Fix incorrect name attribute of ExFileObject (GH-…
Browse files Browse the repository at this point in the history
…102424)

Co-authored-by: Simeon Visser <[email protected]>
  • Loading branch information
arhadthedev and svisser authored Mar 27, 2023
1 parent 89e67ad commit 56d055a
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Lib/tarfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -601,12 +601,12 @@ class _FileInFile(object):
object.
"""

def __init__(self, fileobj, offset, size, blockinfo=None):
def __init__(self, fileobj, offset, size, name, blockinfo=None):
self.fileobj = fileobj
self.offset = offset
self.size = size
self.position = 0
self.name = getattr(fileobj, "name", None)
self.name = name
self.closed = False

if blockinfo is None:
Expand Down Expand Up @@ -703,7 +703,7 @@ class ExFileObject(io.BufferedReader):

def __init__(self, tarfile, tarinfo):
fileobj = _FileInFile(tarfile.fileobj, tarinfo.offset_data,
tarinfo.size, tarinfo.sparse)
tarinfo.size, tarinfo.name, tarinfo.sparse)
super().__init__(fileobj)
#class ExFileObject

Expand Down
7 changes: 7 additions & 0 deletions Lib/test/test_tarfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -479,6 +479,13 @@ def test_length_zero_header(self):
with tarfile.open(support.findfile('recursion.tar')) as tar:
pass

def test_extractfile_name(self):
# gh-74468: TarFile.name must name a file, not a parent archive.
file = self.tar.getmember('ustar/regtype')
with self.tar.extractfile(file) as fobj:
self.assertEqual(fobj.name, 'ustar/regtype')


class MiscReadTestBase(CommonReadTest):
def requires_name_attribute(self):
pass
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Attribute name of the extracted :mod:`tarfile` file object now holds
filename of itself rather than of the archive it is contained in.
Patch by Oleg Iarygin.

0 comments on commit 56d055a

Please sign in to comment.