Skip to content

Commit

Permalink
Add option to trace to run modules (GH-5134)
Browse files Browse the repository at this point in the history
Adds a new option in trace that allows tracing runnable modules. It is
exposed as `--module module_name` as `-m` is already in use for another
argument.
  • Loading branch information
mariocj89 authored and ncoghlan committed Jun 1, 2019
1 parent 664fe39 commit 354227a
Show file tree
Hide file tree
Showing 4 changed files with 41 additions and 16 deletions.
3 changes: 3 additions & 0 deletions Doc/library/trace.rst
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ all Python modules imported during the execution into the current directory.

Display the version of the module and exit.

.. versionadded:: 3.8
Added ``--module`` option that allows to run an executable module.

Main options
^^^^^^^^^^^^

Expand Down
7 changes: 6 additions & 1 deletion Lib/test/test_trace.py
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,7 @@ class TestCommandLine(unittest.TestCase):

def test_failures(self):
_errors = (
(b'filename is missing: required with the main options', '-l', '-T'),
(b'progname is missing: required with the main options', '-l', '-T'),
(b'cannot specify both --listfuncs and (--trace or --count)', '-lc'),
(b'argument -R/--no-report: not allowed with argument -r/--report', '-rR'),
(b'must specify one of --trace, --count, --report, --listfuncs, or --trackcalls', '-g'),
Expand Down Expand Up @@ -524,5 +524,10 @@ def f():
self.assertIn('lines cov% module (path)', stdout)
self.assertIn(f'6 100% {TESTFN} ({filename})', stdout)

def test_run_as_module(self):
assert_python_ok('-m', 'trace', '-l', '--module', 'timeit', '-n', '1')
assert_python_failure('-m', 'trace', '-l', '--module', 'not_a_module_zzz')


if __name__ == '__main__':
unittest.main()
46 changes: 31 additions & 15 deletions Lib/trace.py
Original file line number Diff line number Diff line change
Expand Up @@ -666,7 +666,9 @@ def main():
help='Ignore files in the given directory '
'(multiple directories can be joined by os.pathsep).')

parser.add_argument('filename', nargs='?',
parser.add_argument('--module', action='store_true', default=False,
help='Trace a module. ')
parser.add_argument('progname', nargs='?',
help='file to run as main program')
parser.add_argument('arguments', nargs=argparse.REMAINDER,
help='arguments to the program')
Expand Down Expand Up @@ -704,26 +706,40 @@ def parse_ignore_dir(s):
if opts.summary and not opts.count:
parser.error('--summary can only be used with --count or --report')

if opts.filename is None:
parser.error('filename is missing: required with the main options')

sys.argv = [opts.filename, *opts.arguments]
sys.path[0] = os.path.dirname(opts.filename)
if opts.progname is None:
parser.error('progname is missing: required with the main options')

t = Trace(opts.count, opts.trace, countfuncs=opts.listfuncs,
countcallers=opts.trackcalls, ignoremods=opts.ignore_module,
ignoredirs=opts.ignore_dir, infile=opts.file,
outfile=opts.file, timing=opts.timing)
try:
with open(opts.filename) as fp:
code = compile(fp.read(), opts.filename, 'exec')
# try to emulate __main__ namespace as much as possible
globs = {
'__file__': opts.filename,
'__name__': '__main__',
'__package__': None,
'__cached__': None,
}
if opts.module:
import runpy
module_name = opts.progname
mod_name, mod_spec, code = runpy._get_module_details(module_name)
sys.argv = [code.co_filename, *opts.arguments]
globs = {
'__name__': '__main__',
'__file__': code.co_filename,
'__package__': mod_spec.parent,
'__loader__': mod_spec.loader,
'__spec__': mod_spec,
'__cached__': None,
}
else:
sys.argv = [opts.progname, *opts.arguments]
sys.path[0] = os.path.dirname(opts.progname)

with open(opts.progname) as fp:
code = compile(fp.read(), opts.progname, 'exec')
# try to emulate __main__ namespace as much as possible
globs = {
'__file__': opts.progname,
'__name__': '__main__',
'__package__': None,
'__cached__': None,
}
t.runctx(code, globs, globs)
except OSError as err:
sys.exit("Cannot run file %r because: %s" % (sys.argv[0], err))
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
trace.py can now run modules via python3 -m trace -t --module module_name

0 comments on commit 354227a

Please sign in to comment.