Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed typos of examples in code #1881

Merged
merged 1 commit into from
Feb 19, 2024
Merged

fixed typos of examples in code #1881

merged 1 commit into from
Feb 19, 2024

Conversation

S-Panta
Copy link
Contributor

@S-Panta S-Panta commented Feb 17, 2024 •
edited
Loading

This PR fixes the typos of the example of tiles. The code cannot find CartoBD Voyager in the xyzservices.TileProvider. It should be CartoDB Voyager.
Reference: https://github.com/geopandas/xyzservices/blob/8c3f23830e9d0dd06406d3371610351aae77ed76/xyzservices/data/providers.json#L2075

martinfleis
martinfleis approved these changes Feb 17, 2024
View reviewed changes
Copy link
Collaborator

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Conengmo Conengmo merged commit 226ba52 into python-visualization:main Feb 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinfleis martinfleis martinfleis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@S-Panta @martinfleis @Conengmo