Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoJson: documentation for popup_keep_highlighted argument #1854

Conversation

GiuseppeGalilei
Copy link
Contributor

Related to #1836
I added a small description along with an example, as a small section in the Highlight function paragraph.
I had some problems with building the documentation on my own.
However, I tested the example on my own and it is working correctly, so I believe there shouldn't be any problem.
Beware that, as I'm writing this, the popup_keep_highlighted feature has not yet been officially released.

@GiuseppeGalilei GiuseppeGalilei changed the title Documentation for popup_keep_highlighted argument in the GeoJson class GeoJson: documentation for popup_keep_highlighted argument Jan 2, 2024
Copy link
Member

@Conengmo Conengmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

I'll fix the precommit complaint then merge it.

@Conengmo Conengmo merged commit 688dcc1 into python-visualization:main Jan 2, 2024
12 checks passed
@GiuseppeGalilei GiuseppeGalilei deleted the popup_keep_highlighted-docs branch January 2, 2024 19:28
hansthen pushed a commit to hansthen/folium that referenced this pull request Jan 24, 2024
…isualization#1854)

* added section to geojson.md

* Update geojson.md

---------

Co-authored-by: Frank <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants