LayerControl: fix visibility on multiple renders #1674
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1199
LayerControl has instance attributes that we fill when the
render
method is called. That means that ifrender
is called multiple times, those attributes are changed multiple times. This leads to bugs.The desired behavior is that each time
render
is called, the instance attributes act as if the instance was freshly created. Achieve this by calling thereset
method at the beginning of therender
method. This way, each timerender
is called, empty instance attributes are used.