Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at #1316 and #1033, this seemed like an obvious improvement that doesn't actually increase the parameter footprint of the
Map
class.With this change a user doesn't have to do the following:
but can do this directly:
Discussion
I still think we should be careful to add more parameters to
Map
, to prevent it from becoming a god-class. IfMap
has the same parameters asTileLayer
, we are doing something wrong. I think we should stick withMap
having thetiles
argument as a convenience, and have users useTileLayer
when they want to do more advanced things.Maybe a way to make this more clear is by allowing the
tiles
argument ofMap
to only be one of the pre-defined string arguments or aTileLayer
, but not a custom url. Users wanting to use a custom url are thus forced to useTileLayer
. That way we could also scrap theattr
argument ofMap
.Since that would mean breaking changes for some users, I don't think we should actually go ahead with that.