feat: add Leaflet.VectorGrid plugin #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a good candidate for a plugin, given our plugin acceptance criteria. https://github.com/python-visualization/folium/blob/main/.github/CONTRIBUTING.md#plugin-acceptence-criteria PR is also good. I'll rebase so we can run some more tests. |
Conengmo
force-pushed
the
feat/add-vectorgrid-plugin
branch
from
a56614d
to
54df3eb
Compare
|
Thanks @iwpnd! |
This was referenced Nov 10, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
I wanted to use vector map tile layers in folium with streamlit and was surprised that Leaflet.VectorGrid is not yet part of the folium plugin ecosystem.
Let me know what you think and if you don't want to consider this PR I'd be happy if folium-vector could be linked instead.