Make the next release the last Py2 version #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good news, the number of Py2 users of folium is dropping since January. Seems our pending deprecation warning has had effect. I got this graph from https://pypistats.org/packages/folium
Note that it's still at 25 %, not an insignificant amount.
I propose we make the next release the last to support Python 2. To make sure the message is heard I upgraded the warning to a
UserWarning, which means it will show on all systems by default.Then for the release after that we have to make sure users cannot install it on Python 2. More on how to achieve that here: https://python3statement.org/practicalities/