Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace deprecated pep517.build by build #5155

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

finswimmer
Copy link
Member

pep517's higher-level functions which install the build dependencies into a temporary environment and build a wheel/sdist using them, are deprecated. The recommended way of doing it, is to use build. This is done by this PR. The changes are a more or less shameless copy of the implementation in the build cli.

Resolves: #2983

@finswimmer finswimmer requested a review from a team February 5, 2022 20:27
@abn abn self-assigned this Feb 26, 2022
Copy link
Member

@abn abn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes with one functional change (runner configuration).

src/poetry/inspection/info.py Outdated Show resolved Hide resolved
src/poetry/inspection/info.py Outdated Show resolved Hide resolved
src/poetry/inspection/info.py Outdated Show resolved Hide resolved
@abn abn removed their assignment Feb 26, 2022
@abn abn merged commit e05ad9b into python-poetry:master Feb 28, 2022
@finswimmer finswimmer mentioned this pull request Mar 6, 2022
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull in pep517 high-level interfaces into poetry codebase
3 participants