Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixtures: fix non-working package-scope parametrization reordering #12329

Merged
merged 1 commit into from
May 16, 2024
Merged

fixtures: fix non-working package-scope parametrization reordering #12329

merged 1 commit into from
May 16, 2024

Conversation

bluetech
Copy link
Member

The .parent was incorrectly removed in
a21fb87, but it was actually correct (well, it assumes that Module.path.parent == Package.path, which I'm not sure is always correct, but that's a different matter). Restore it.

Fix #12328.

@bluetech
fixtures: fix non-working package-scope parametrization reordering
1acf56d 
The `.parent` was incorrectly removed in
a21fb87, but it was actually correct
(well, it assumes that Module.path.parent == Package.path, which I'm not
sure is always correct, but that's a different matter). Restore it.

Fix #12328.
@bluetech bluetech merged commit fdf3aa3 into main May 16, 2024
23 checks passed
@bluetech bluetech deleted the fix-package-scope-reorder branch May 16, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pytest 8 broke sorting for package-scoped fixtures
2 participants
@bluetech @nicoddemus