Swap venv and virtualenv checks #7719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Environments created by pypa/virtualenv >=20 can pass both real_prefix and base_prefix checks, but are only able to use the pyvenv.cfg values, not the legacy `no-global-site-packages.txt`. So we need to check for venv (PEP 405) first.
uranusjr
force-pushed
the
virtualenv-20-detection
branch
from
ecbac9f
to
6104060
Compare
pradyunsg
approved these changes
Feb 11, 2020
xavfernandez
approved these changes
Feb 11, 2020
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #7718.
Environments created by pypa/virtualenv >=20 can pass both
real_prefixandbase_prefixchecks, but are only able to use thepyvenv.cfgvalues, not the legacyno-global-site-packages.txt. This patch swap the checks to test for venv (PEP 405) first, so the new virtualenv implementation uses the correct code path and readspyvenv.cfg.